Merge pull request ClickHouse#87948 from ClickHouse/backport/25.8/87442

Backport ClickHouse#87442 to 25.8: Fix bool decoding in parquet reader v3

Author: alexey-milovidov

src/Processors/Formats/Impl/Parquet/Decoding.cpp

@@ -249,7 +249,7 @@ struct PlainBooleanDecoder : public PageDecoder
                 /// x = 00000000 000000hg 00000000 000000fe 00000000 000000dc 00000000 000000ba
                 x = (x | (x <<  7)) & 0x0101010101010101ul;
                 /// x = 0000000h 0000000g 0000000f 0000000e 0000000d 0000000c 0000000b 0000000a
-                memcpy(to + i * 8, &x, 8);
+                memcpy(to + i, &x, 8);
                 i += 8;
             }
             else

tests/queries/0_stateless/03630_parquet_bool_bug.reference

@@ -0,0 +1,2 @@
+8
+256

tests/queries/0_stateless/03630_parquet_bool_bug.sql

@@ -0,0 +1,8 @@
+-- Tags: no-parallel, no-fasttest
+
+insert into function file('03630_parquet_bool_bug.parquet', Parquet, 'tags Array(Bool)') settings engine_file_truncate_on_insert=1 values ([false,false,false,false,false,false,false,false]), ([true,true,true,true,true,true,true,true]);
+select sum(tags) from file('03630_parquet_bool_bug.parquet') array join tags settings input_format_parquet_use_native_reader_v3=1;
+
+-- Try all 256 1-byte masks to verify the bit shifting nonsense in PlainBooleanDecoder.
+insert into function file('03630_parquet_bool_bug.parquet') select number as n, arrayMap(i -> toBool(bitShiftRight(number, i) % 2 = 1), range(8)) as bits from numbers(256) settings engine_file_truncate_on_insert=1;
+select sum(n = arraySum(arrayMap(i -> bitShiftLeft(bits[i+1], i), range(8)))) as ok from file('03630_parquet_bool_bug.parquet') settings input_format_parquet_use_native_reader_v3=1, schema_inference_make_columns_nullable=0;