Fix tidy build

Author: ianton-ru

src/Storages/ObjectStorage/DataLakes/DataLakeConfiguration.h

@@ -268,7 +268,7 @@ class StorageIcebergConfiguration : public StorageObjectStorage::Configuration,
 
     Path getRawPath() const override { return getImpl().getRawPath(); }
     const Path & getPathForRead() const override { return getImpl().getPathForRead(); }
-    Path getPathForWrite(const std::string & partition_id = "") const override { return getImpl().getPathForWrite(partition_id); }
+    Path getPathForWrite(const std::string & partition_id) const override { return getImpl().getPathForWrite(partition_id); }
 
     void setPathForRead(const Path & path) override { getImpl().setPathForRead(path); }
 
@@ -333,7 +333,7 @@ class StorageIcebergConfiguration : public StorageObjectStorage::Configuration,
     }
 
     void initPartitionStrategy(ASTPtr partition_by, const ColumnsDescription & columns, ContextPtr context) override
-        { return getImpl().initPartitionStrategy(partition_by, columns, context); }
+        { getImpl().initPartitionStrategy(partition_by, columns, context); }
 
     std::optional<ColumnsDescription> tryGetTableStructureFromMetadata() const override
         { return getImpl().tryGetTableStructureFromMetadata(); }
@@ -388,7 +388,7 @@ class StorageIcebergConfiguration : public StorageObjectStorage::Configuration,
 
     PartitionStrategyFactory::StrategyType getPartitionStrategyType() const override { return getImpl().getPartitionStrategyType(); }
     bool getPartitionColumnsInDataFile() const override { return getImpl().getPartitionColumnsInDataFile(); }
-    const std::shared_ptr<IPartitionStrategy> getPartitionStrategy() const override { return getImpl().getPartitionStrategy(); }
+    std::shared_ptr<IPartitionStrategy> getPartitionStrategy() const override { return getImpl().getPartitionStrategy(); }
 
     void setFormat(const String & format_) override { getImpl().setFormat(format_); }
     void setCompressionMethod(const String & compression_method_) override { getImpl().setCompressionMethod(compression_method_); }

src/Storages/ObjectStorage/StorageObjectStorage.h

@@ -225,7 +225,7 @@ class StorageObjectStorage::Configuration
 
     virtual const Path & getPathForRead() const;
     // Path used for writing, it should not be globbed and might contain a partition key
-    virtual Path getPathForWrite(const std::string & partition_id = "") const;
+    virtual Path getPathForWrite(const std::string & partition_id) const;
 
     virtual void setPathForRead(const Path & path)
     {
@@ -333,7 +333,7 @@ class StorageObjectStorage::Configuration
 
     virtual PartitionStrategyFactory::StrategyType getPartitionStrategyType() const { return partition_strategy_type; }
     virtual bool getPartitionColumnsInDataFile() const { return partition_columns_in_data_file; }
-    virtual const std::shared_ptr<IPartitionStrategy> getPartitionStrategy() const { return partition_strategy; }
+    virtual std::shared_ptr<IPartitionStrategy> getPartitionStrategy() const { return partition_strategy; }
 
     virtual void setFormat(const String & format_) { format = format_; }
     virtual void setCompressionMethod(const String & compression_method_) { compression_method = compression_method_; }