address pr comments

Author: arthurpassos

docs/en/engines/table-engines/mergetree-family/part_export.md

@@ -105,7 +105,7 @@ destination_database:          default
 destination_table:             destination_table
 create_time:                   2025-11-19 09:09:11
 part_name:                     20251016-365_1_1_0
-destination_file_paths:        ['table_root/eventDate=2025-10-16/retention=365/20251016-365_1_1_0_17B2F6CD5D3C18E787C07AE3DAF16EB1.parquet']
+destination_file_paths:        ['table_root/eventDate=2025-10-16/retention=365/20251016-365_1_1_0_17B2F6CD5D3C18E787C07AE3DAF16EB1.1.parquet']
 elapsed:                       2.04845441
 rows_read:                     1138688 -- 1.14 million
 total_rows_to_read:            550961374 -- 550.96 million
@@ -151,7 +151,7 @@ partition:               2021
 part_type:               Compact
 disk_name:               default
 path_on_disk:            
-remote_file_paths        ['year=2021/2021_0_0_0_78C704B133D41CB0EF64DD2A9ED3B6BA.parquet']
+remote_file_paths        ['year=2021/2021_0_0_0_78C704B133D41CB0EF64DD2A9ED3B6BA.1.parquet']
 rows:                    1
 size_in_bytes:           272
 merged_from:             ['2021_0_0_0']

src/Storages/IStorage.h

@@ -466,7 +466,7 @@ It is currently only implemented in StorageObjectStorage.
     virtual SinkToStoragePtr import(
         const std::string & /* file_name */,
         Block & /* block_with_partition_values */,
-        std::function<void(const std::string &)> /* new_file_path_callback */,
+        const std::function<void(const std::string &)> & /* new_file_path_callback */,
         bool /* overwrite_if_exists */,
         std::size_t /* max_bytes_per_file */,
         std::size_t /* max_rows_per_file */,

src/Storages/MergeTree/ExportPartitionUtils.cpp

@@ -76,14 +76,14 @@ namespace ExportPartitionUtils
 
         if (exported_paths.empty())
         {
-            LOG_INFO(log, "ExportPartition: No exported paths found, will not commit export. This might be a bug");
+            LOG_WARNING(log, "ExportPartition: No exported paths found, will not commit export. This might be a bug");
             return;
         }
 
         //// not checking for an exact match because a single part might generate multiple files
         if (exported_paths.size() < manifest.parts.size())
         {
-            LOG_INFO(log, "ExportPartition: Reached the commit phase, but exported paths size is less than the number of parts, will not commit export. This might be a bug");
+            LOG_WARNING(log, "ExportPartition: Reached the commit phase, but exported paths size is less than the number of parts, will not commit export. This might be a bug");
             return;
         }
 

src/Storages/ObjectStorage/MultiFileStorageObjectStorageSink.cpp

@@ -19,7 +19,7 @@ MultiFileStorageObjectStorageSink::MultiFileStorageObjectStorageSink(
     std::size_t max_bytes_per_file_,
     std::size_t max_rows_per_file_,
     bool overwrite_if_exists_,
-    std::function<void(const std::string &)> new_file_path_callback_,
+    const std::function<void(const std::string &)> & new_file_path_callback_,
     const std::optional<FormatSettings> & format_settings_,
     SharedHeader sample_block_,
     ContextPtr context_)
@@ -72,6 +72,7 @@ std::shared_ptr<StorageObjectStorageSink> MultiFileStorageObjectStorageSink::cre
 {
     auto new_path = generateNewFilePath();
 
+    /// todo
     /// sounds like bad design, but callers might decide to ignore the exception, and if we throw it before the callback
     /// they will not be able to grab the file path.
     /// maybe I should consider moving the file already exists policy in here?

src/Storages/ObjectStorage/MultiFileStorageObjectStorageSink.h

@@ -19,7 +19,7 @@ class MultiFileStorageObjectStorageSink : public SinkToStorage
         std::size_t max_bytes_per_file_,
         std::size_t max_rows_per_file_,
         bool overwrite_if_exists_,
-        std::function<void(const std::string &)> new_file_path_callback_,
+        const std::function<void(const std::string &)> & new_file_path_callback_,
         const std::optional<FormatSettings> & format_settings_,
         SharedHeader sample_block_,
         ContextPtr context_);

src/Storages/ObjectStorage/StorageObjectStorage.cpp

@@ -502,7 +502,7 @@ bool StorageObjectStorage::supportsImport() const
 SinkToStoragePtr StorageObjectStorage::import(
     const std::string & file_name,
     Block & block_with_partition_values,
-    std::function<void(const std::string &)> new_file_path_callback,
+    const std::function<void(const std::string &)> & new_file_path_callback,
     bool overwrite_if_exists,
     std::size_t max_bytes_per_file,
     std::size_t max_rows_per_file,

src/Storages/ObjectStorage/StorageObjectStorage.h

@@ -87,7 +87,7 @@ class StorageObjectStorage : public IStorage
     SinkToStoragePtr import(
         const std::string & /* file_name */,
         Block & /* block_with_partition_values */,
-        std::function<void(const std::string &)> new_file_path_callback,
+        const std::function<void(const std::string &)> & new_file_path_callback,
         bool /* overwrite_if_exists */,
         std::size_t /* max_bytes_per_file */,
         std::size_t /* max_rows_per_file */,

src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp

@@ -576,7 +576,7 @@ bool StorageObjectStorageCluster::supportsImport() const
 SinkToStoragePtr StorageObjectStorageCluster::import(
     const std::string & file_name,
     Block & block_with_partition_values,
-    std::function<void(const std::string &)> new_file_path_callback,
+    const std::function<void(const std::string &)> & new_file_path_callback,
     bool overwrite_if_exists,
     std::size_t max_bytes_per_file,
     std::size_t max_rows_per_file,

src/Storages/ObjectStorage/StorageObjectStorageCluster.h

@@ -128,7 +128,7 @@ class StorageObjectStorageCluster : public IStorageCluster
     SinkToStoragePtr import(
         const std::string & /* file_name */,
         Block & /* block_with_partition_values */,
-        std::function<void(const std::string &)> /* new_file_path_callback */,
+        const std::function<void(const std::string &)> & /* new_file_path_callback */,
         bool /* overwrite_if_exists */,
         std::size_t /* max_bytes_per_file */,
         std::size_t /* max_rows_per_file */,