Skip to content

Commit 36fdc10

Browse files
committed
disable azure tests for external PRs
1 parent 4afdd2c commit 36fdc10

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

ci/jobs/functional_tests.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,19 @@ def main():
191191
runner_options += f" --jobs {nproc}"
192192

193193
if not info.is_local_run:
194+
# NOTE(strtgbb): We pass azure credentials through the docker command, not SSM.
194195
# TODO: find a way to work with Azure secret so it's ok for local tests as well, for now keep azure disabled
195196
# os.environ["AZURE_CONNECTION_STRING"] = Shell.get_output(
196197
# f"aws ssm get-parameter --region us-east-1 --name azure_connection_string --with-decryption --output text --query Parameter.Value",
197198
# verbose=True,
198199
# )
199-
# NOTE(strtgbb): We pass azure credentials through the docker command, not SSM.
200-
pass
200+
201+
# NOTE(strtgbb): Azure credentials don't exist in community workflow
202+
if info.is_community_pr:
203+
print(
204+
"NOTE: No azure credentials provided for community PR - disable azure storage"
205+
)
206+
config_installs_args += " --no-azure"
201207
else:
202208
print("Disable azure for a local run")
203209
config_installs_args += " --no-azure"

ci/praktika/info.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ def repo_owner(self):
9393
def fork_name(self):
9494
return self.env.FORK_NAME
9595

96+
@property
97+
def is_community_pr(self):
98+
return "Community" in self.env.WORKFLOW_NAME
99+
96100
@property
97101
def user_name(self):
98102
return self.env.USER_LOGIN

tests/config/config.d/azure_storage_conf.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
<object_storage_type>azure</object_storage_type>
77
<skip_access_check>false</skip_access_check>
88
<max_single_part_upload_size>33554432</max_single_part_upload_size>
9-
<storage_account_url from_env="AZURE_STORAGE_ACCOUNT_URL">
10-
https://127.0.0.1:10000/devstoreaccount1
11-
</storage_account_url>
9+
<storage_account_url from_env="AZURE_STORAGE_ACCOUNT_URL"/>
1210
<container_name from_env="AZURE_CONTAINER_NAME"/>
1311
<account_name from_env="AZURE_ACCOUNT_NAME"/>
1412
<account_key from_env="AZURE_STORAGE_KEY"/>

0 commit comments

Comments
 (0)