Skip to content

Commit 3d00a89

Browse files
committed
Attempt to fix stateless test 02995_new_settings_history.sh
1 parent cf4d137 commit 3d00a89

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

src/Core/SettingsChangesHistory.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
4444
{"allow_experimental_iceberg_read_optimization", true, true, "New setting."},
4545
{"object_storage_cluster_join_mode", "allow", "allow", "New setting"},
4646
{"lock_object_storage_task_distribution_ms", 500, 500, "Raised the value to 500 to avoid hoping tasks between executors."},
47-
{"object_storage_cluster", "", "", "New setting"},
48-
{"object_storage_max_nodes", 0, 0, "New setting"},
4947
{"allow_retries_in_cluster_requests", false, false, "New setting"},
5048
{"object_storage_remote_initiator", false, false, "New setting."},
5149
});
@@ -143,13 +141,6 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
143141
{"distributed_plan_force_shuffle_aggregation", 0, 0, "New experimental setting"},
144142
{"allow_experimental_insert_into_iceberg", false, false, "New setting."},
145143
/// RELEASE CLOSED
146-
{"allow_experimental_database_iceberg", false, true, "Turned ON by default for Antalya"},
147-
{"allow_experimental_database_unity_catalog", false, true, "Turned ON by default for Antalya"},
148-
{"allow_experimental_database_glue_catalog", false, true, "Turned ON by default for Antalya"},
149-
{"output_format_parquet_enum_as_byte_array", true, true, "Enable writing Enum as byte array in Parquet by default"},
150-
{"lock_object_storage_task_distribution_ms", 0, 0, "New setting."},
151-
{"object_storage_cluster", "", "", "New setting"},
152-
{"object_storage_max_nodes", 0, 0, "New setting"},
153144
});
154145
addSettingsChanges(settings_changes_history, "25.6.5.2000",
155146
{
@@ -161,6 +152,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
161152
{"object_storage_max_nodes", 0, 0, "New setting"},
162153
{"allow_experimental_export_merge_tree_part", false, false, "New setting."},
163154
{"export_merge_tree_part_overwrite_file_if_exists", false, false, "New setting."},
155+
{"lock_object_storage_task_distribution_ms", 0, 0, "New setting."},
164156
});
165157
addSettingsChanges(settings_changes_history, "25.6",
166158
{

tests/queries/0_stateless/02995_new_settings_history.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ fi
2323

2424
# Note that this is a broad check. A per version check is done in the upgrade test
2525
# Baselines generated with v25.7.1 (pre-release)
26-
# clickhouse local --query "select name, default from system.settings order by name format TSV" > 02995_settings_25_7_1.tsv
27-
# clickhouse local --query "select name, value from system.merge_tree_settings order by name format TSV" > 02995_merge_tree_settings_settings_25_7_1.tsv
26+
# clickhouse local --query "select name, default from system.settings WHERE NOT has((select flatten(groupArray(changes.name)) from system.settings_changes where version >= '25.8'), name) order by name format TSV" > 02995_settings_25_7_1.tsv
27+
# clickhouse local --query "select name, value from system.merge_tree_settings WHERE NOT has((select flatten(groupArray(changes.name)) from system.settings_changes where version >= '25.8'), name) order by name format TSV" > 02995_merge_tree_settings_settings_25_7_1.tsv
2828
$CLICKHOUSE_LOCAL --query "
2929
WITH old_settings AS
3030
(

tests/queries/0_stateless/02995_settings_25_7_1.tsv

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ allow_experimental_database_replicated 1
3535
allow_experimental_database_unity_catalog 0
3636
allow_experimental_delta_kernel_rs 1
3737
allow_experimental_dynamic_type 1
38+
allow_experimental_export_merge_tree_part 0
39+
allow_experimental_export_merge_tree_part 0
3840
allow_experimental_full_text_index 0
3941
allow_experimental_funnel_functions 0
4042
allow_experimental_geo_types 1
@@ -360,6 +362,7 @@ engine_url_skip_empty_files 0
360362
errors_output_format CSV
361363
exact_rows_before_limit 0
362364
except_default_mode ALL
365+
export_merge_tree_part_overwrite_file_if_exists 0
363366
external_storage_connect_timeout_sec 10
364367
external_storage_max_read_bytes 0
365368
external_storage_max_read_rows 0
@@ -584,13 +587,13 @@ input_format_parquet_case_insensitive_column_matching 0
584587
input_format_parquet_enable_json_parsing 1
585588
input_format_parquet_enable_row_group_prefetch 1
586589
input_format_parquet_filter_push_down 1
587-
input_format_parquet_use_metadata_cache 1
588590
input_format_parquet_import_nested 0
589591
input_format_parquet_local_file_min_bytes_for_seek 8192
590592
input_format_parquet_max_block_size 65409
591593
input_format_parquet_prefer_block_bytes 16744704
592594
input_format_parquet_preserve_order 0
593595
input_format_parquet_skip_columns_with_unsupported_types_in_schema_inference 0
596+
input_format_parquet_use_metadata_cache 1
594597
input_format_parquet_use_native_reader 0
595598
input_format_protobuf_flatten_google_wrappers 0
596599
input_format_protobuf_skip_fields_with_unsupported_types_in_schema_inference 0
@@ -863,6 +866,8 @@ network_zstd_compression_level 1
863866
normalize_function_names 1
864867
number_of_mutations_to_delay 0
865868
number_of_mutations_to_throw 0
869+
object_storage_cluster
870+
object_storage_max_nodes 0
866871
odbc_bridge_connection_pool_size 16
867872
odbc_bridge_use_connection_pooling 1
868873
odbc_max_field_size 0
@@ -948,7 +953,6 @@ output_format_json_map_as_array_of_tuples 0
948953
output_format_json_named_tuples_as_objects 1
949954
output_format_json_pretty_print 1
950955
output_format_json_quote_64bit_floats 0
951-
output_format_json_quote_64bit_integers 1
952956
output_format_json_quote_decimals 0
953957
output_format_json_quote_denormals 0
954958
output_format_json_skip_null_value_in_named_tuples 0

0 commit comments

Comments
 (0)