Backport ClickHouse#91386 to 25.8: Reset async_insert value in the queue

Author: robot-clickhouse

src/Interpreters/AsynchronousInsertQueue.cpp

@@ -826,8 +826,8 @@ try
     /// 'resetParser' doesn't work for parallel parsing.
     key.settings->set("input_format_parallel_parsing", false);
     /// It maybe insert into distributed table.
-    /// It doesn't make sense to make insert into destination tables asynchronous.
-    key.settings->set("async_insert", false);
+    /// We want the remote part to decide if the insert will be async or not.
+    key.settings->setDefaultValue("async_insert");
 
     insert_context->makeQueryContext();
 

tests/queries/0_stateless/03748_async_insert_reset_setting.reference

@@ -0,0 +1,20 @@
+2
+4
+1	test1
+1	test1
+2	test2
+2	test2
+3	test3
+3	test3
+4	test4
+4	test4
+5	test5
+5	test5
+6	test6
+6	test6
+7	test7
+7	test7
+8	test8
+8	test8
+9	test9
+9	test9

tests/queries/0_stateless/03748_async_insert_reset_setting.sh

@@ -0,0 +1,72 @@
+#!/usr/bin/env bash
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CURDIR"/../shell_config.sh
+
+SYNC_USER="${CLICKHOUSE_DATABASE}_sync_user"
+ASYNC_USER="${CLICKHOUSE_DATABASE}_async_user"
+
+${CLICKHOUSE_CLIENT} --multiquery <<EOF
+DROP TABLE IF EXISTS source_table, target_table, target_table_remote_sync, target_table_remote_async, async_insert_mv, sync_insert_mv;
+DROP USER IF EXISTS ${SYNC_USER}, ${ASYNC_USER};
+
+CREATE USER ${SYNC_USER} HOST ANY IDENTIFIED WITH NO_PASSWORD SETTINGS async_insert = 0;
+CREATE USER ${ASYNC_USER} HOST ANY IDENTIFIED WITH NO_PASSWORD SETTINGS async_insert = 1;
+GRANT ALL ON target_table TO ${SYNC_USER};
+GRANT ALL ON target_table TO ${ASYNC_USER};
+
+CREATE TABLE source_table (
+    id UInt64,
+    data String
+)
+ENGINE=MergeTree()
+ORDER BY id;
+
+CREATE TABLE target_table (
+    id UInt64,
+    data String
+)
+ENGINE=MergeTree()
+ORDER BY id;
+
+CREATE TABLE target_table_remote_sync (
+    id UInt64,
+    data String
+)
+AS remote('127.0.0.2', currentDatabase(), 'target_table', '${SYNC_USER}');
+
+CREATE TABLE target_table_remote_async (
+    id UInt64,
+    data String
+)
+AS remote('127.0.0.2', currentDatabase(), 'target_table', '${ASYNC_USER}');
+
+CREATE MATERIALIZED VIEW async_insert_mv TO target_table_remote_async AS
+SELECT * FROM source_table;
+
+CREATE MATERIALIZED VIEW sync_insert_mv TO target_table_remote_sync AS
+SELECT * FROM source_table;
+
+-- Default setting, unset async_insert, so its default is 0
+SET async_insert = DEFAULT;
+-- One type of inserts each
+INSERT INTO source_table (id, data) VALUES (1, 'test1'), (2, 'test2'), (3, 'test3');
+SET async_insert = 1;
+-- One type of inserts each
+INSERT INTO source_table (id, data) VALUES (4, 'test4'), (5, 'test5'), (6, 'test6');
+SET async_insert = 0;
+-- This time both inserts have async_insert = 0, so 2 async and 4 sync inserts in total
+INSERT INTO source_table (id, data) VALUES (7, 'test7'), (8, 'test8'), (9, 'test9');
+
+SYSTEM FLUSH LOGS query_log;
+SELECT count() FROM system.query_log
+WHERE query_kind = 'Insert' AND type = 'QueryFinish'
+  AND user IN ('${SYNC_USER}', '${ASYNC_USER}')
+--  AND current_database = currentDatabase() -- to silent strange style check warning
+  AND tables = [currentDatabase() || '.target_table']
+GROUP BY Settings['async_insert']
+ORDER BY count() ASC;
+
+SELECT * FROM target_table ORDER BY id;
+EOF