Skip to content

Commit 634c6da

Browse files
committed
remove unneeded info
1 parent 343d7d6 commit 634c6da

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -680,11 +680,6 @@ String composeList(
680680
auto d = field->getValue<String>("direction");
681681
expr += (Poco::icompare(d, "desc") == 0) ? " DESC" : " ASC";
682682
}
683-
if (field->has("null-order"))
684-
{
685-
auto n = field->getValue<String>("null-order");
686-
expr += (Poco::icompare(n, "nulls-last") == 0) ? " NULLS LAST" : " NULLS FIRST";
687-
}
688683
}
689684

690685
parts.push_back(std::move(expr));

tests/integration/test_storage_iceberg/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3453,7 +3453,7 @@ def test_system_tables_partition_sorting_keys(started_cluster, storage_type):
34533453
WHERE name = '{table_name}' FORMAT csv
34543454
""").strip().lower()
34553455

3456-
assert res == '"bucket(16, id), day(ts)","id desc nulls last, hour(ts) asc nulls first"'
3456+
assert res == '"bucket(16, id), day(ts)","id desc, hour(ts) asc"'
34573457

34583458
@pytest.mark.parametrize("storage_type", ["local", "s3"])
34593459
def test_compressed_metadata(started_cluster, storage_type):

0 commit comments

Comments
 (0)