Backport ClickHouse#91573 to 25.8: Disallow ALTERs for Object Storage table engines

Author: robot-clickhouse

src/Storages/ObjectStorage/StorageObjectStorageConfiguration.h

@@ -213,7 +213,16 @@ class StorageObjectStorageConfiguration
         const std::optional<FormatSettings> & /*format_settings*/) {}
     virtual void checkMutationIsPossible(const MutationCommands & /*commands*/) {}
 
-    virtual void checkAlterIsPossible(const AlterCommands & /*commands*/) {}
+    virtual void checkAlterIsPossible(const AlterCommands & commands)
+    {
+        for (const auto & command : commands)
+        {
+            if (!command.isCommentAlter())
+                throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Alter of type '{}' is not supported by storage {}",
+                    command.type, getEngineName());
+        }
+    }
+
     virtual void alter(const AlterCommands & /*params*/, ContextPtr /*context*/) {}
 
     virtual const DataLakeStorageSettings & getDataLakeSettings() const

tests/queries/0_stateless/03629_storage_s3_disallow_index_alter.reference

@@ -0,0 +1,10 @@
+-- Tags: no-fasttest
+-- Tag no-fasttest: Depends on S3
+-- Issue: https://github.com/ClickHouse/ClickHouse/issues/87059
+
+DROP TABLE IF EXISTS test_03629;
+CREATE TABLE test_03629 (a UInt64) ENGINE = S3(s3_conn, filename='test_03629_{_partition_id}', format='Native') PARTITION BY a;
+ALTER TABLE test_03629 ADD INDEX a_idx a TYPE set(0); -- { serverError NOT_IMPLEMENTED }
+ALTER TABLE test_03629 ADD PROJECTION a_proj (SELECT a + 1 ORDER BY a); -- { serverError NOT_IMPLEMENTED }
+
+DROP TABLE test_03629;