Add tests

Author: ianton-ru

src/Storages/IStorageCluster.cpp

@@ -251,6 +251,7 @@ void IStorageCluster::updateQueryWithJoinToSendIfNeeded(
                 auto cross_join_node = join_searcher.getNode();
                 if (!cross_join_node)
                     throw Exception(ErrorCodes::LOGICAL_ERROR, "Can't find CROSS JOIN node");
+                // CrossJoinNode contains vector of nodes. 0 is left expression, always exists.
                 query_tree_distributed = cross_join_node->as<CrossJoinNode>()->getTableExpressions()[0]->clone();
             }
 

tests/integration/test_database_iceberg/test.py

@@ -781,3 +781,17 @@ def test_cluster_joins(started_cluster):
     )
 
     assert res == "Jack\nJohn\n"
+
+    res = node.query(
+        f"""
+            SELECT t1.name,t2.second_name
+            FROM {CATALOG_NAME}.`{root_namespace}.{table_name}` AS t1
+                CROSS JOIN `{table_name_local}` AS t2
+            ORDER BY ALL
+            SETTINGS
+                object_storage_cluster='cluster_simple',
+                object_storage_cluster_join_mode='local'
+        """
+    )
+
+    assert res == "Jack\tBlack\nJack\tSilver\nJohn\tBlack\nJohn\tSilver\n"

tests/integration/test_storage_iceberg/test.py

@@ -3638,6 +3638,20 @@ def execute_spark_query(query: str, table_name):
 
     assert res == "jack\njohn\n"
 
+    res = instance.query(
+        f"""
+            SELECT t1.name,t2.second_name
+            FROM {creation_expression} AS t1
+                CROSS JOIN `{TABLE_NAME_LOCAL}` AS t2
+            ORDER BY ALL
+            SETTINGS
+                object_storage_cluster='cluster_simple',
+                object_storage_cluster_join_mode='local'
+        """
+    )
+
+    assert res == "jack\tblack\njack\tsilver\njohn\tblack\njohn\tsilver\n"
+
 
 @pytest.mark.parametrize("storage_type", ["s3"])
 def test_system_tables_partition_sorting_keys(started_cluster, storage_type):