Skip to content

Commit 78ab809

Browse files
committed
small polish
1 parent 9a8abbd commit 78ab809

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/Disks/ObjectStorages/IObjectStorage.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,7 @@ void PathWithMetadata::loadMetadata(ObjectStoragePtr object_storage, bool ignore
148148
{
149149
const auto & path = isArchive() ? getPathToArchive() : getPath();
150150

151-
auto storage_to_use = object_storage;
152-
153-
if (auto storage_for_file = getObjectStorage(); storage_for_file.has_value())
154-
storage_to_use = storage_for_file.value();
151+
auto storage_to_use = object_storage_to_use.value_or(object_storage);
155152

156153
if (ignore_non_existent_file)
157154
metadata = storage_to_use->tryGetObjectMetadata(path);

src/Storages/ObjectStorage/StorageObjectStorageSource.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,6 @@ StorageObjectStorageSource::ReaderHolder StorageObjectStorageSource::createReade
484484
ObjectInfoPtr object_info;
485485
auto query_settings = configuration->getQuerySettings(context_);
486486

487-
ObjectStoragePtr storage_to_use = object_storage;
488-
489487
bool not_a_path = false;
490488

491489
do
@@ -516,6 +514,8 @@ StorageObjectStorageSource::ReaderHolder StorageObjectStorageSource::createReade
516514
object_info->loadMetadata(object_storage, query_settings.ignore_non_existent_file);
517515
}
518516
while (not_a_path || (query_settings.skip_empty_files && object_info->metadata->size_bytes == 0));
517+
518+
ObjectStoragePtr storage_to_use = object_info->getObjectStorage().value_or(object_storage);
519519

520520
QueryPipelineBuilder builder;
521521
std::shared_ptr<ISource> source;

0 commit comments

Comments
 (0)