Merge pull request ClickHouse#87275 from ClickHouse/backport/25.8/86414

Backport ClickHouse#86414 to 25.8: Fail if all replicas are unavailable when reading from *cluster functions

Author: nickitat

src/Storages/IStorageCluster.cpp

@@ -42,6 +42,11 @@ namespace Setting
     extern const SettingsNonZeroUInt64 max_parallel_replicas;
 }
 
+namespace ErrorCodes
+{
+    extern const int ALL_CONNECTION_TRIES_FAILED;
+}
+
 IStorageCluster::IStorageCluster(
     const String & cluster_name_,
     const StorageID & table_id_,
@@ -239,10 +244,10 @@ void ReadFromCluster::initializePipeline(QueryPipelineBuilder & pipeline, const
         pipes.emplace_back(std::move(pipe));
     }
 
-    auto pipe = Pipe::unitePipes(std::move(pipes));
-    if (pipe.empty())
-        pipe = Pipe(std::make_shared<NullSource>(getOutputHeader()));
+    if (pipes.empty())
+        throw Exception(ErrorCodes::ALL_CONNECTION_TRIES_FAILED, "Cannot connect to any replica for query execution");
 
+    auto pipe = Pipe::unitePipes(std::move(pipes));
     for (const auto & processor : pipe.getProcessors())
         processors.emplace_back(processor);
 

tests/config/config.d/clusters.xml

@@ -325,5 +325,19 @@
                 </replica>
             </shard>
         </test_shard_bind_host_fail>
+        <test_cluster_multiple_nodes_all_unavailable>
+            <node>
+                <host>127.0.0.1</host>
+                <port>1234</port>
+            </node>
+            <node>
+                <host>127.0.0.2</host>
+                <port>1234</port>
+            </node>
+            <node>
+                <host>127.0.0.3</host>
+                <port>1234</port>
+            </node>
+        </test_cluster_multiple_nodes_all_unavailable>
     </remote_servers>
 </clickhouse>

tests/queries/0_stateless/03603_reading_s3_cluster_all_nodes_unavailable.reference

@@ -0,0 +1,4 @@
+-- Tags: no-fasttest
+-- s3Cluster is not used in fast tests
+
+SELECT * FROM s3Cluster('test_cluster_multiple_nodes_all_unavailable', 'http://localhost:11111/test/a.tsv'); -- { serverError ALL_CONNECTION_TRIES_FAILED }