Skip to content

Commit a85e763

Browse files
committed
get rid of old helpers
1 parent 6f6e06d commit a85e763

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,9 @@ ManifestFileContent::ManifestFileContent(
286286

287287
const auto file_path_key
288288
= manifest_file_deserializer.getValueFromRowByName(i, c_data_file_file_path, TypeIndex::String).safeGet<String>();
289-
const auto file_path = getProperFilePathFromMetadataInfo(
290-
manifest_file_deserializer.getValueFromRowByName(i, c_data_file_file_path, TypeIndex::String).safeGet<String>(),
291-
common_path,
289+
const auto file_path = makeAbsolutePath(
292290
table_location,
293-
common_namespace);
291+
manifest_file_deserializer.getValueFromRowByName(i, c_data_file_file_path, TypeIndex::String).safeGet<String>());
294292

295293
/// NOTE: This is weird, because in manifest file partition looks like this:
296294
/// {

src/Storages/ObjectStorage/DataLakes/Iceberg/StatelessMetadataFileGetter.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,7 @@ ManifestFileCacheKeys getManifestList(
160160
{
161161
const std::string file_path
162162
= manifest_list_deserializer.getValueFromRowByName(i, f_manifest_path, TypeIndex::String).safeGet<std::string>();
163-
const auto manifest_file_name = getProperFilePathFromMetadataInfo(
164-
file_path,
165-
configuration_ptr->getPathForRead().path,
166-
persistent_table_components.table_location,
167-
configuration_ptr->getNamespace());
163+
const auto manifest_file_name = makeAbsolutePath(persistent_table_components.table_location, file_path);
168164
Int64 added_sequence_number = 0;
169165
auto added_snapshot_id = manifest_list_deserializer.getValueFromRowByName(i, f_added_snapshot_id);
170166
if (added_snapshot_id.isNull())

0 commit comments

Comments
 (0)