Backport ClickHouse#91827 to 25.8: Fix LOGICAL_ERROR in RecursiveCTEChunkGenerator

Author: robot-clickhouse

src/Processors/Sources/RecursiveCTESource.cpp

@@ -38,7 +38,7 @@ namespace ErrorCodes
 namespace
 {
 
-std::vector<TableNode *> collectTableNodesWithStorage(const StoragePtr & storage, IQueryTreeNode * root)
+std::vector<TableNode *> collectTableNodesWithTemporaryTableName(const std::string & temporary_table_name, IQueryTreeNode * root)
 {
     std::vector<TableNode *> result;
 
@@ -51,7 +51,7 @@ std::vector<TableNode *> collectTableNodesWithStorage(const StoragePtr & storage
         nodes_to_process.pop_back();
 
         auto * table_node = subtree_node->as<TableNode>();
-        if (table_node && table_node->getStorageID() == storage->getStorageID())
+        if (table_node && table_node->getTemporaryTableName() == temporary_table_name)
             result.push_back(table_node);
 
         for (auto & child : subtree_node->getChildren())
@@ -77,7 +77,9 @@ class RecursiveCTEChunkGenerator
         chassert(recursive_cte_union_node_typed.hasRecursiveCTETable());
 
         auto & recursive_cte_table = recursive_cte_union_node_typed.getRecursiveCTETable();
-        recursive_table_nodes = collectTableNodesWithStorage(recursive_cte_table->storage, recursive_cte_union_node.get());
+
+        const auto & cte_name = recursive_cte_union_node_typed.getCTEName();
+        recursive_table_nodes = collectTableNodesWithTemporaryTableName(cte_name, recursive_cte_union_node.get());
         if (recursive_table_nodes.empty())
             throw Exception(ErrorCodes::LOGICAL_ERROR, "UNION query {} is not recursive", recursive_cte_union_node->formatASTForErrorMessage());
 

tests/queries/0_stateless/03755_nested_recursive_cte.reference

@@ -0,0 +1,21 @@
+DROP TABLE IF EXISTS t0;
+CREATE TABLE t0 (x Int32) ENGINE = Memory;
+INSERT INTO t0 VALUES (1);
+
+-- The original problematic query pattern - inner CTE references outer CTE
+-- Using count() to get deterministic output regardless of how many rows are produced before hitting the limit
+SET max_recursive_cte_evaluation_depth = 5;
+SET enable_analyzer = 1;
+
+SELECT count() > 0 FROM (
+  WITH RECURSIVE q AS (
+    SELECT 1 FROM t0 UNION ALL
+      (WITH RECURSIVE x AS
+        (SELECT 1 FROM t0 UNION ALL
+          (SELECT 1 FROM q WHERE FALSE UNION ALL
+           SELECT 1 FROM x WHERE FALSE))
+         SELECT 1 FROM x))
+    SELECT 1 FROM q
+); -- { serverError TOO_DEEP_RECURSION }
+
+DROP TABLE t0;