Skip to content

Commit bfb72ae

Browse files
committed
minor changes
1 parent 9f9fcb2 commit bfb72ae

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

src/Interpreters/Context.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
#include <mutex>
3333
#include <optional>
3434

35-
#include "Storages/ExportsList.h"
36-
3735

3836
namespace Poco::Net
3937
{
@@ -90,6 +88,7 @@ class AsynchronousMetrics;
9088
class BackgroundSchedulePool;
9189
class MergeList;
9290
class MovesList;
91+
class ExportsList;
9392
class ReplicatedFetchList;
9493
class RefreshSet;
9594
class Cluster;

src/Storages/MergeTree/MergeTreeData.h

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1239,20 +1239,6 @@ class MergeTreeData : public IStorage, public WithMutableContext
12391239
/// under lockForShare if rename is possible.
12401240
String relative_data_path;
12411241

1242-
/// RAII Wrapper for atomic work with currently moving parts
1243-
/// Acquire them in constructor and remove them in destructor
1244-
/// Uses data.currently_moving_parts_mutex
1245-
struct CurrentlyMovingPartsTagger
1246-
{
1247-
MergeTreeMovingParts parts_to_move;
1248-
MergeTreeData & data;
1249-
CurrentlyMovingPartsTagger(MergeTreeMovingParts && moving_parts_, MergeTreeData & data_);
1250-
1251-
~CurrentlyMovingPartsTagger();
1252-
};
1253-
1254-
using CurrentlyMovingPartsTaggerPtr = std::shared_ptr<CurrentlyMovingPartsTagger>;
1255-
12561242
private:
12571243
/// Columns and secondary indices sizes can be calculated lazily.
12581244
mutable std::mutex columns_and_secondary_indices_sizes_mutex;
@@ -1687,7 +1673,19 @@ class MergeTreeData : public IStorage, public WithMutableContext
16871673
DataPartsVector * out_covered_parts,
16881674
bool rename_in_transaction);
16891675

1676+
/// RAII Wrapper for atomic work with currently moving parts
1677+
/// Acquire them in constructor and remove them in destructor
1678+
/// Uses data.currently_moving_parts_mutex
1679+
struct CurrentlyMovingPartsTagger
1680+
{
1681+
MergeTreeMovingParts parts_to_move;
1682+
MergeTreeData & data;
1683+
CurrentlyMovingPartsTagger(MergeTreeMovingParts && moving_parts_, MergeTreeData & data_);
1684+
1685+
~CurrentlyMovingPartsTagger();
1686+
};
16901687

1688+
using CurrentlyMovingPartsTaggerPtr = std::shared_ptr<CurrentlyMovingPartsTagger>;
16911689

16921690
/// Moves part to specified space, used in ALTER ... MOVE ... queries
16931691
std::future<MovePartsOutcome> movePartsToSpace(const CurrentlyMovingPartsTaggerPtr & moving_tagger, const ReadSettings & read_settings, const WriteSettings & write_settings, bool async);

src/Storages/MergeTree/MergeTreeExportManifest.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ namespace DB
2424
* "transaction_id": "<id>",
2525
* "partition_id": "<partition_id>",
2626
* "destination": "<database>.<table>",
27+
* "completed": <true/false>,
2728
* "parts": [ {"part_name": "name", "remote_path": "path-or-empty"}, ... ]
2829
* }
2930
*/

src/Storages/ObjectStorage/StorageObjectStorage.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include <Processors/Transforms/ExtractColumnsTransform.h>
2020

2121
#include <Storages/Cache/SchemaCache.h>
22+
#include <Storages/ExportsList.h>
2223
#include <Storages/NamedCollectionsHelpers.h>
2324
#include <Storages/ObjectStorage/ReadBufferIterator.h>
2425
#include <Storages/ObjectStorage/StorageObjectStorageSink.h>

0 commit comments

Comments
 (0)