make sure to use '1' not 'true'

Author: strtgbb

.github/workflows/backport_branches.yml

@@ -17,7 +17,7 @@ env:
   # Force the stdout and stderr streams to be unbuffered
   PYTHONUNBUFFERED: 1
   DISABLE_CI_MERGE_COMMIT: ${{ vars.DISABLE_CI_MERGE_COMMIT || '0' }}
-  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache || '0' }}
+  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache && '1' || '0' }}
   CHECKOUT_REF: ${{ vars.DISABLE_CI_MERGE_COMMIT == '1' && github.event.pull_request.head.sha || '' }}
   DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
   CLICKHOUSE_TEST_STAT_URL: ${{ secrets.CLICKHOUSE_TEST_STAT_URL }}

.github/workflows/master.yml

@@ -16,7 +16,7 @@ on:
 env:
   # Force the stdout and stderr streams to be unbuffered
   PYTHONUNBUFFERED: 1
-  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache || '0' }}
+  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache && '1' || '0' }}
   CHECKOUT_REF: ""
   DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
   CLICKHOUSE_TEST_STAT_URL: ${{ secrets.CLICKHOUSE_TEST_STAT_URL }}

.github/workflows/pull_request.yml

@@ -17,7 +17,7 @@ env:
   # Force the stdout and stderr streams to be unbuffered
   PYTHONUNBUFFERED: 1
   DISABLE_CI_MERGE_COMMIT: ${{ vars.DISABLE_CI_MERGE_COMMIT || '0' }}
-  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache || '0' }}
+  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache && '1' || '0' }}
   CHECKOUT_REF: ${{ vars.DISABLE_CI_MERGE_COMMIT == '1' && github.event.pull_request.head.sha || '' }}
   DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
   CLICKHOUSE_TEST_STAT_URL: ${{ secrets.CLICKHOUSE_TEST_STAT_URL }}

.github/workflows/release_branches.yml

@@ -16,7 +16,7 @@ on:
 env:
   # Force the stdout and stderr streams to be unbuffered
   PYTHONUNBUFFERED: 1
-  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache || '0' }}
+  DISABLE_CI_CACHE: ${{ github.event.inputs.no_cache && '1' || '0' }}
   CHECKOUT_REF: ""
   DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
   CLICKHOUSE_TEST_STAT_URL: ${{ secrets.CLICKHOUSE_TEST_STAT_URL }}

ci/praktika/native_jobs.py

@@ -360,10 +360,7 @@ def _check_db(workflow):
             )
         )
 
-    pr_allows_cache = (
-        "[x] <!---no_ci_cache" not in Info().pr_body
-        or os.environ.get("DISABLE_CI_CACHE", "0") not in ("1", "true")
-    )
+    pr_allows_cache = "[x] <!---no_ci_cache" not in Info().pr_body
     if (
         workflow.enable_job_filtering_by_changes
         and results[-1].is_ok()

ci/praktika/yaml_generator.py

@@ -61,11 +61,11 @@ class Templates:
 """
         TEMPLATE_ENV_CHECKOUT_REF_PR = """\
   DISABLE_CI_MERGE_COMMIT: ${{{{ vars.DISABLE_CI_MERGE_COMMIT || '0' }}}}
-  DISABLE_CI_CACHE: ${{{{ github.event.inputs.no_cache || '0' }}}}
+  DISABLE_CI_CACHE: ${{{{ github.event.inputs.no_cache && '1' || '0' }}}}
   CHECKOUT_REF: ${{{{ vars.DISABLE_CI_MERGE_COMMIT == '1' && github.event.pull_request.head.sha || '' }}}}\
 """
         TEMPLATE_ENV_CHECKOUT_REF_PUSH = """\
-  DISABLE_CI_CACHE: ${{{{ github.event.inputs.no_cache || '0' }}}}
+  DISABLE_CI_CACHE: ${{{{ github.event.inputs.no_cache && '1' || '0' }}}}
   CHECKOUT_REF: ""\
 """
         TEMPLATE_ENV_CHECKOUT_REF_DEFAULT = """\