Merge pull request ClickHouse#84169 from Avogar/enum-as-byte-array-parquet

Enable output_format_parquet_enum_as_byte_array by default

Author: Avogar

src/Core/FormatFactorySettings.h

@@ -1021,10 +1021,7 @@ Where in the parquet file to place the bloom filters. Bloom filters will be writ
   * if greater than the total size of all bloom filters, bloom filters for all row groups will be accumulated in memory, then written together near the end of the file,
   * otherwise, bloom filters will be accumulated in memory and written out whenever their total size goes above this value.
 )", 0) \
-    DECLARE(Bool, output_format_parquet_datetime_as_uint32, false, R"(
-Write DateTime values as raw unix timestamp (read back as UInt32), instead of converting to milliseconds (read back as DateTime64(3)).
-)", 0) \
-    DECLARE(Bool, output_format_parquet_enum_as_byte_array, false, R"(
+    DECLARE(Bool, output_format_parquet_enum_as_byte_array, true, R"(
 Write enum using parquet physical type: BYTE_ARRAY and logical type: ENUM
 )", 0) \
     DECLARE(String, output_format_avro_codec, "", R"(

src/Core/SettingsChangesHistory.cpp

@@ -70,7 +70,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
 
         addSettingsChanges(settings_changes_history, "25.6.5.2000",
         {
-            {"output_format_parquet_enum_as_byte_array", false, false, "Write enum using parquet physical type: BYTE_ARRAY and logical type: ENUM"},
+            {"output_format_parquet_enum_as_byte_array", true, true, "Enable writing Enum as byte array in Parquet by default"},
         });
         addSettingsChanges(settings_changes_history, "25.6",
         {

tests/queries/0_stateless/02735_parquet_encoder.sql

@@ -7,6 +7,7 @@ set output_format_parquet_batch_size = 100;
 set output_format_parquet_row_group_size_bytes = 1000000000;
 set engine_file_truncate_on_insert=1;
 set allow_suspicious_low_cardinality_types=1;
+set output_format_parquet_enum_as_byte_array=0;
 
 -- Write random data to parquet file, then read from it and check that it matches what we wrote.
 -- Do this for all kinds of data types: primitive, Nullable(primitive), Array(primitive),