Merge pull request ClickHouse#86734 from ClickHouse/backport/25.8/86391

clickhouse-gh[bot] · web-flow · commit d24d27b07bb1 · 2025-09-05T14:43:16.000+01:00
Backport ClickHouse#86391 to 25.8: Skip DataLake tables for `DROP REPLICA`
diff --git a/src/Interpreters/InterpreterSystemQuery.cpp b/src/Interpreters/InterpreterSystemQuery.cpp
@@ -1133,7 +1133,7 @@ void InterpreterSystemQuery::dropReplica(ASTSystemQuery & query)
     {
         getContext()->checkAccess(AccessType::SYSTEM_DROP_REPLICA, query.getDatabase());
         DatabasePtr database = DatabaseCatalog::instance().getDatabase(query.getDatabase());
-        for (auto iterator = database->getTablesIterator(getContext()); iterator->isValid(); iterator->next())
+        for (auto iterator = database->getLightweightTablesIterator(getContext()); iterator->isValid(); iterator->next())
             dropReplicaImpl(query, iterator->table());
         LOG_TRACE(log, "Dropped replica {} from database {}", query.replica, backQuoteIfNeed(database->getDatabaseName()));
     }

Original file line number	Diff line number	Diff line change
`@@ -1133,7 +1133,7 @@ void InterpreterSystemQuery::dropReplica(ASTSystemQuery & query)`
`1133`	`1133`	`{`
`1134`	`1134`	`getContext()->checkAccess(AccessType::SYSTEM_DROP_REPLICA, query.getDatabase());`
`1135`	`1135`	`DatabasePtr database = DatabaseCatalog::instance().getDatabase(query.getDatabase());`
`1136`		`- for (auto iterator = database->getTablesIterator(getContext()); iterator->isValid(); iterator->next())`
	`1136`	`+ for (auto iterator = database->getLightweightTablesIterator(getContext()); iterator->isValid(); iterator->next())`
`1137`	`1137`	`dropReplicaImpl(query, iterator->table());`
`1138`	`1138`	`LOG_TRACE(log, "Dropped replica {} from database {}", query.replica, backQuoteIfNeed(database->getDatabaseName()));`
`1139`	`1139`	`}`