Skip to content

Commit d36f86b

Browse files
committed
Merge remote-tracking branch 'altinity/25.6/settings_update_lock_object_storage_task_distribution_ms' into bugfix/antalya-25.6.5/lock_object_storage_task_distribution_ms_lost_host
2 parents 45acc4d + ed68e8b commit d36f86b

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

src/Core/Settings.cpp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6891,8 +6891,18 @@ Cache the list of objects returned by list objects calls in object storage
68916891
DECLARE(Bool, distributed_plan_optimize_exchanges, true, R"(
68926892
Removes unnecessary exchanges in distributed query plan. Disable it for debugging.
68936893
)", 0) \
6894-
DECLARE(UInt64, lock_object_storage_task_distribution_ms, 0, R"(
6895-
In object storage distribution queries do not distibute tasks on non-prefetched nodes until prefetched node is active.
6894+
DECLARE(UInt64, lock_object_storage_task_distribution_ms, 500, R"(
6895+
In object storage distribution queries do not distribute tasks on non-prefetched nodes until prefetched node is active.
6896+
Determines how long the free executor node (one that finished processing all of it assigned tasks) should wait before "stealing" tasks from queue of currently busy executor nodes.
6897+
6898+
Possible values:
6899+
6900+
- 0 - steal tasks immediately after freeing up.
6901+
- >0 - wait for specified period of time before stealing tasks.
6902+
6903+
Having this `>0` helps with cache reuse and might improve overall query time.
6904+
Because busy node might have warmed-up caches for this specific task, while free node needs to fetch lots of data from S3.
6905+
Which might take longer than just waiting for the busy node and generate extra traffic.
68966906
)", EXPERIMENTAL) \
68976907
DECLARE(String, distributed_plan_force_exchange_kind, "", R"(
68986908
Force specified kind of Exchange operators between distributed query stages.

src/Core/SettingsChangesHistory.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,11 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
6767
/// controls new feature and it's 'true' by default, use 'false' as previous_value).
6868
/// It's used to implement `compatibility` setting (see https://github.com/ClickHouse/ClickHouse/issues/35972)
6969
/// Note: please check if the key already exists to prevent duplicate entries.
70-
addSettingsChanges(settings_changes_history, "25.6.5.2000",
70+
addSettingsChanges(settings_changes_history, "25.6.5.20364",
71+
{
72+
{"lock_object_storage_task_distribution_ms", 500, 500, "Raised the value to 500 to avoid hoping tasks between executors."},
73+
});
74+
addSettingsChanges(settings_changes_history, "25.6.5.20000",
7175
{
7276
{"allow_experimental_database_iceberg", false, true, "Turned ON by default for Antalya"},
7377
{"allow_experimental_database_unity_catalog", false, true, "Turned ON by default for Antalya"},

0 commit comments

Comments
 (0)