Skip to content

Commit f8caa7f

Browse files
committed
Remove optimiation for NULLs
1 parent bb2da6b commit f8caa7f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/Storages/ObjectStorage/StorageObjectStorageSource.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ StorageObjectStorageSource::ReaderHolder StorageObjectStorageSource::createReade
646646
}
647647
}
648648
}
649-
649+
/*
650650
for (const auto & column : requested_columns_list)
651651
{
652652
const auto & column_name = column.first;
@@ -671,6 +671,7 @@ StorageObjectStorageSource::ReaderHolder StorageObjectStorageSource::createReade
671671
column.second.first,
672672
column.second.second.type);
673673
}
674+
*/
674675
}
675676

676677
if (!constant_columns.empty())

tests/integration/test_storage_iceberg/test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3689,11 +3689,11 @@ def get_events(query_id, event):
36893689
events_all_data_optimized = get_events(all_data_query_id, event) # 1-2025, 6-2025 must not be read
36903690
events_const_only_optimized = get_events(const_only_query_id, event) # All must not be read
36913691
events_const_partial_optimized = get_events(const_partial_query_id, event) # 1-2025, 6-2025 and 2-2025 must not be read
3692-
events_const_partial2_optimized = get_events(const_partial2_query_id, event) # 1-2024, 1-2025, 2-2025 and 6-2025 must not be read
3692+
events_const_partial2_optimized = get_events(const_partial2_query_id, event) # 6-2025 must not be read, 1-2024, 1-2025, 2-2025 readed because of nulls
36933693
events_count_optimized = get_events(count_query_id, event) # All must not be read
36943694

3695-
assert events_all_data_optimized == 5
3695+
assert events_all_data_optimized == 6 # 5
36963696
assert events_const_only_optimized == 0
36973697
assert events_const_partial_optimized == 4
3698-
assert events_const_partial2_optimized == 3
3698+
assert events_const_partial2_optimized == 6
36993699
assert events_count_optimized == 0

0 commit comments

Comments
 (0)