Merge pull request ClickHouse#87639 from ClickHouse/backport/25.8/86967

Backport ClickHouse#86967 to 25.8: fix CTE deterministic functions

Author: yakov-olkhovskiy

src/Analyzer/Resolve/IdentifierResolveScope.h

@@ -198,14 +198,6 @@ struct IdentifierResolveScope
     /// Node hash to mask id map
     std::shared_ptr<std::map<IQueryTreeNode::Hash, size_t>> projection_mask_map;
 
-    struct ResolvedFunctionsCache
-    {
-        FunctionOverloadResolverPtr resolver;
-        FunctionBasePtr function_base;
-    };
-
-    std::map<IQueryTreeNode::Hash, ResolvedFunctionsCache> functions_cache;
-
     [[maybe_unused]] const IdentifierResolveScope * getNearestQueryScope() const;
 
     IdentifierResolveScope * getNearestQueryScope();

src/Analyzer/Resolve/QueryAnalyzer.cpp

@@ -3511,19 +3511,26 @@ ProjectionNames QueryAnalyzer::resolveFunction(QueryTreeNodePtr & node, Identifi
     FunctionOverloadResolverPtr function = UserDefinedExecutableFunctionFactory::instance().tryGet(function_name, scope.context, parameters); /// NOLINT(readability-static-accessed-through-instance)
     bool is_executable_udf = true;
 
-    IdentifierResolveScope::ResolvedFunctionsCache * function_cache = nullptr;
+    ResolvedFunctionsCache * function_cache = nullptr;
 
     if (!function)
     {
         /// This is a hack to allow a query like `select randConstant(), randConstant(), randConstant()`.
         /// Function randConstant() would return the same value for the same arguments (in scope).
+        /// But we need to exclude getSetting() function because SETTINGS can change its result for every scope.
 
-        auto hash = function_node_ptr->getTreeHash();
-        function_cache = &scope.functions_cache[hash];
-        if (!function_cache->resolver)
-            function_cache->resolver = FunctionFactory::instance().tryGet(function_name, scope.context);
+        if (function_name != "getSetting" && function_name != "rowNumberInAllBlocks")
+        {
+            auto hash = function_node_ptr->getTreeHash();
+
+            function_cache = &functions_cache[hash];
+            if (!function_cache->resolver)
+                function_cache->resolver = FunctionFactory::instance().tryGet(function_name, scope.context);
 
-        function = function_cache->resolver;
+            function = function_cache->resolver;
+        }
+        else
+            function = FunctionFactory::instance().tryGet(function_name, scope.context);
 
         is_executable_udf = false;
     }

src/Analyzer/Resolve/QueryAnalyzer.h

@@ -12,6 +12,7 @@
 #include <Core/NamesAndTypes.h>
 
 #include <Parsers/NullsAction.h>
+#include <Functions/IFunction.h>
 
 namespace DB
 {
@@ -296,6 +297,14 @@ class QueryAnalyzer
 
     std::unordered_map<QueryTreeNodePtr, IdentifierResolveScope> node_to_scope_map;
 
+    struct ResolvedFunctionsCache
+    {
+        FunctionOverloadResolverPtr resolver;
+        FunctionBasePtr function_base;
+    };
+
+    std::map<IQueryTreeNode::Hash, ResolvedFunctionsCache> functions_cache;
+
     const bool only_analyze;
 };
 

src/Functions/getSetting.cpp

@@ -37,6 +37,7 @@ class FunctionGetSetting : public IFunction, WithContext
 
     String getName() const override { return name; }
     bool isDeterministic() const override { return false; }
+    bool isDeterministicInScopeOfQuery() const override { return false; }
     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return false; }
     size_t getNumberOfArguments() const override { return (mode == ErrorHandlingMode::Default) ? 2 : 1 ; }
     ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {0, 1}; }

tests/queries/0_stateless/03611_cte_deterministic.reference

@@ -0,0 +1,3 @@
+1
+1
+1	1	1

tests/queries/0_stateless/03611_cte_deterministic.sql

@@ -0,0 +1,5 @@
+set enable_analyzer = 1;
+
+with (select randConstant()) as a select a = a;
+with (select now() + sleep(1)) as a select a = a;
+with (select randConstant()) as b select b = b, a = b, `a=a` from (with (select randConstant()) as a select a, a = a as `a=a`);