Skip to content

Commit 18ffa09

Browse files
Slachaider-chat-bot
andcommitted
chore: remove unnecessary comments from previous refactoring
Co-authored-by: aider (anthropic/claude-opus-4-5-20251101) <[email protected]>
1 parent e1adfe5 commit 18ffa09

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

pkg/backup/create.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,6 @@ func (b *Backuper) createBackupLocal(ctx context.Context, backupName, diffFromRe
301301
}
302302
}
303303

304-
// Check all tables for consistent column types BEFORE any freeze operations
305-
// This avoids having unfrozen data parts if only one table contains inconsistent column data types
306-
// https://github.com/Altinity/clickhouse-backup/issues/529
307304
if b.cfg.ClickHouse.CheckPartsColumns && doBackupData {
308305
tablesToCheck := make([]clickhouse.Table, 0, len(tables))
309306
for _, table := range tables {
@@ -908,9 +905,6 @@ func (b *Backuper) AddTableToLocalBackup(ctx context.Context, backupName string,
908905
}
909906
return nil, nil, nil, nil, nil
910907
}
911-
// Note: CheckPartsColumns is now done for all tables at once in createBackupLocal
912-
// before any AddTableToLocalBackup calls to avoid unfrozen data parts on failure
913-
// backup data
914908
if err := b.ch.FreezeTable(ctx, table, shadowBackupUUID); err != nil {
915909
return nil, nil, nil, nil, err
916910
}

pkg/clickhouse/clickhouse.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1391,22 +1391,18 @@ func (ch *ClickHouse) CheckReplicationInProgress(table metadata.TableMetadata) (
13911391
return true, nil
13921392
}
13931393

1394-
// ColumnDataTypesWithTable extends ColumnDataTypes with database and table information for batch queries
13951394
type ColumnDataTypesWithTable struct {
13961395
Database string `ch:"database"`
13971396
Table string `ch:"table"`
13981397
Column string `ch:"column"`
13991398
Types []string `ch:"uniq_types"`
14001399
}
14011400

1402-
// CheckSystemPartsColumns check data parts types consistency https://github.com/Altinity/clickhouse-backup/issues/529#issuecomment-1554460504
14031401
func (ch *ClickHouse) CheckSystemPartsColumns(ctx context.Context, table *Table) error {
14041402
tables := []Table{*table}
14051403
return ch.CheckSystemPartsColumnsForTables(ctx, tables)
14061404
}
14071405

1408-
// CheckSystemPartsColumnsForTables checks data parts types consistency for multiple tables using a single SQL query
1409-
// This avoids having unfrozen data parts if only one table contains inconsistent column data types
14101406
func (ch *ClickHouse) CheckSystemPartsColumnsForTables(ctx context.Context, tables []Table) error {
14111407
if len(tables) == 0 {
14121408
return nil

0 commit comments

Comments
 (0)