Skip to content

Commit 3fb5c2b

Browse files
committed
refactoring integration_test.go
Signed-off-by: Slach <[email protected]>
1 parent 42b4f86 commit 3fb5c2b

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

test/integration/integration_test.go

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -490,20 +490,20 @@ func NewTestEnvironment(t *testing.T) (*TestEnvironment, *require.Assertions) {
490490
func (env *TestEnvironment) Cleanup(t *testing.T, r *require.Assertions) {
491491
env.ch.Close()
492492

493-
if t.Name() == "TestIntegrationS3" || t.Name() == "TestIntegrationEmbedded" {
493+
if t.Name() == "TestS3" || t.Name() == "TestEmbedded" {
494494
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/disk_s3")
495495
}
496496

497-
if t.Name() == "TestRBAC" || t.Name() == "TestConfigs" || t.Name() == "TestIntegrationEmbedded" {
497+
if t.Name() == "TestRBAC" || t.Name() == "TestConfigs" || t.Name() == "TestEmbedded" {
498498
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/backups_s3")
499499
}
500-
if t.Name() == "TestIntegrationCustomRsync" {
500+
if t.Name() == "TestCustomRsync" {
501501
env.DockerExecNoError(r, "sshd", "rm", "-rf", "/root/rsync_backups")
502502
}
503-
if t.Name() == "TestIntegrationCustomRestic" {
503+
if t.Name() == "TestCustomRestic" {
504504
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/restic")
505505
}
506-
if t.Name() == "TestIntegrationCustomKopia" {
506+
if t.Name() == "TestCustomKopia" {
507507
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/kopia")
508508
}
509509

@@ -663,7 +663,7 @@ func TestChangeReplicationPathIfReplicaExists(t *testing.T) {
663663
env.Cleanup(t, r)
664664
}
665665

666-
func TestIntegrationEmbedded(t *testing.T) {
666+
func TestEmbedded(t *testing.T) {
667667
version := os.Getenv("CLICKHOUSE_VERSION")
668668
if compareVersion(version, "23.3") < 0 {
669669
t.Skipf("Test skipped, BACKUP/RESTORE not production ready for %s version, look https://github.com/ClickHouse/ClickHouse/issues/39416 for details", version)
@@ -706,7 +706,7 @@ func TestIntegrationEmbedded(t *testing.T) {
706706
env.Cleanup(t, r)
707707
}
708708

709-
func TestIntegrationAzure(t *testing.T) {
709+
func TestAzure(t *testing.T) {
710710
if isTestShouldSkip("AZURE_TESTS") {
711711
t.Skip("Skipping Azure integration tests...")
712712
return
@@ -731,7 +731,7 @@ func TestIntegrationAzure(t *testing.T) {
731731
env.Cleanup(t, r)
732732
}
733733

734-
func TestIntegrationGCSWithCustomEndpoint(t *testing.T) {
734+
func TestGCSWithCustomEndpoint(t *testing.T) {
735735
if isTestShouldSkip("GCS_TESTS") {
736736
t.Skip("Skipping GCS_EMULATOR integration tests...")
737737
return
@@ -741,14 +741,14 @@ func TestIntegrationGCSWithCustomEndpoint(t *testing.T) {
741741
env.Cleanup(t, r)
742742
}
743743

744-
func TestIntegrationS3(t *testing.T) {
744+
func TestS3(t *testing.T) {
745745
env, r := NewTestEnvironment(t)
746746
env.checkObjectStorageIsEmpty(t, r, "S3")
747747
env.runMainIntegrationScenario(t, "S3", "config-s3.yml")
748748
env.Cleanup(t, r)
749749
}
750750

751-
func TestIntegrationAlibabaOverS3(t *testing.T) {
751+
func TestAlibabaOverS3(t *testing.T) {
752752
if os.Getenv("QA_ALIBABA_SECRET_KEY") == "" {
753753
t.Skip("Skipping Alibabacloud integration tests... QA_ALIBABA_SECRET_KEY missing")
754754
return
@@ -760,7 +760,7 @@ func TestIntegrationAlibabaOverS3(t *testing.T) {
760760
env.Cleanup(t, r)
761761
}
762762

763-
func TestIntegrationCOS(t *testing.T) {
763+
func TestCOS(t *testing.T) {
764764
if os.Getenv("QA_TENCENT_SECRET_KEY") == "" {
765765
t.Skip("Skipping Tencent Cloud Object Storage integration tests... QA_TENCENT_SECRET_KEY missing")
766766
return
@@ -772,7 +772,7 @@ func TestIntegrationCOS(t *testing.T) {
772772
env.Cleanup(t, r)
773773
}
774774

775-
func TestIntegrationGCS(t *testing.T) {
775+
func TestGCS(t *testing.T) {
776776
if isTestShouldSkip("GCS_TESTS") {
777777
t.Skip("Skipping GCS integration tests...")
778778
return
@@ -782,20 +782,20 @@ func TestIntegrationGCS(t *testing.T) {
782782
env.Cleanup(t, r)
783783
}
784784

785-
func TestIntegrationSFTPAuthKey(t *testing.T) {
785+
func TestSFTPAuthKey(t *testing.T) {
786786
env, r := NewTestEnvironment(t)
787787
env.uploadSSHKeys(r, "clickhouse-backup")
788788
env.runMainIntegrationScenario(t, "SFTP", "config-sftp-auth-key.yaml")
789789
env.Cleanup(t, r)
790790
}
791791

792-
func TestIntegrationSFTPAuthPassword(t *testing.T) {
792+
func TestSFTPAuthPassword(t *testing.T) {
793793
env, r := NewTestEnvironment(t)
794794
env.runMainIntegrationScenario(t, "SFTP", "config-sftp-auth-password.yaml")
795795
env.Cleanup(t, r)
796796
}
797797

798-
func TestIntegrationFTP(t *testing.T) {
798+
func TestFTP(t *testing.T) {
799799
env, r := NewTestEnvironment(t)
800800
// 21.8 can't execute SYSTEM RESTORE REPLICA
801801
if compareVersion(os.Getenv("CLICKHOUSE_VERSION"), "21.8") > 1 {
@@ -806,7 +806,7 @@ func TestIntegrationFTP(t *testing.T) {
806806
env.Cleanup(t, r)
807807
}
808808

809-
func TestIntegrationS3Glacier(t *testing.T) {
809+
func TestS3Glacier(t *testing.T) {
810810
if isTestShouldSkip("GLACIER_TESTS") {
811811
t.Skip("Skipping GLACIER integration tests...")
812812
return
@@ -821,7 +821,7 @@ func TestIntegrationS3Glacier(t *testing.T) {
821821
env.Cleanup(t, r)
822822
}
823823

824-
func TestIntegrationCustomKopia(t *testing.T) {
824+
func TestCustomKopia(t *testing.T) {
825825
env, r := NewTestEnvironment(t)
826826
env.InstallDebIfNotExists(r, "clickhouse-backup", "ca-certificates", "curl")
827827
env.DockerExecNoError(r, "clickhouse-backup", "update-ca-certificates")
@@ -836,7 +836,7 @@ func TestIntegrationCustomKopia(t *testing.T) {
836836
env.Cleanup(t, r)
837837
}
838838

839-
func TestIntegrationCustomRestic(t *testing.T) {
839+
func TestCustomRestic(t *testing.T) {
840840
env, r := NewTestEnvironment(t)
841841
env.InstallDebIfNotExists(r, "clickhouse-backup", "ca-certificates", "curl")
842842
env.DockerExecNoError(r, "clickhouse-backup", "update-ca-certificates")
@@ -847,7 +847,7 @@ func TestIntegrationCustomRestic(t *testing.T) {
847847
env.Cleanup(t, r)
848848
}
849849

850-
func TestIntegrationCustomRsync(t *testing.T) {
850+
func TestCustomRsync(t *testing.T) {
851851
env, r := NewTestEnvironment(t)
852852
env.uploadSSHKeys(r, "clickhouse-backup")
853853
env.InstallDebIfNotExists(r, "clickhouse-backup", "ca-certificates", "curl")

0 commit comments

Comments
 (0)