add creation integration tables for POST /restart and kill -SIGHUP reaction, fix #1195

Signed-off-by: Slach <[email protected]>

Author: Slach

ChangeLog.md

@@ -1,3 +1,7 @@
+# v2.6.33
+BUG FIXES
+- add creation integration tables for `POST /restart` and `kill -SIGHUP` reaction, fix [1195](https://github.com/Altinity/clickhouse-backup/issues/1195)
+
 # v2.6.32
 IMPROVEMENTS
 - add `--format` for `list` command which support json, yaml, csv, tsv, fix [1192](https://github.com/Altinity/clickhouse-backup/issues/1192), thanks @minguyen9988

pkg/server/server.go

@@ -91,11 +91,6 @@ func Run(cliCtx *cli.Context, cliApp *cli.App, configPath string, clickhouseBack
 		metrics:                 metrics.NewAPIMetrics(),
 		stop:                    make(chan struct{}),
 	}
-	if cfg.API.CreateIntegrationTables {
-		if err := api.CreateIntegrationTables(); err != nil {
-			log.Error().Err(err).Send()
-		}
-	}
 	api.metrics.RegisterMetrics()
 
 	log.Info().Msgf("Starting API server %s on %s", api.cliApp.Version, api.config.API.ListenAddr)
@@ -127,14 +122,14 @@ func Run(cliCtx *cli.Context, cliApp *cli.App, configPath string, clickhouseBack
 	for {
 		select {
 		case <-api.restart:
-			if err := api.Restart(); err != nil {
-				log.Error().Msgf("Failed to restarting API server: %v", err)
+			if restartErr := api.Restart(); restartErr != nil {
+				log.Error().Msgf("Failed to restarting API server: %v", restartErr)
 				continue
 			}
 			log.Info().Msgf("Reloaded by HTTP")
 		case <-sighup:
-			if err := api.Restart(); err != nil {
-				log.Error().Msgf("Failed to restarting API server: %v", err)
+			if restartErr := api.Restart(); restartErr != nil {
+				log.Error().Msgf("Failed to restarting API server: %v", restartErr)
 				continue
 			}
 			log.Info().Msg("Reloaded by SIGHUP")
@@ -171,6 +166,11 @@ func (api *APIServer) Restart() error {
 	if err != nil {
 		return err
 	}
+	if api.config.API.CreateIntegrationTables {
+		if createErr := api.CreateIntegrationTables(); createErr != nil {
+			log.Error().Err(createErr).Send()
+		}
+	}
 	status.Current.CancelAll("canceled via API /restart")
 	if api.server != nil {
 		_ = api.server.Close()