Skip to content

Commit 957c595

Browse files
committed
fixes for TestSkipNotExistsTable
Signed-off-by: Slach <bloodjazman@gmail.com>
1 parent 1a8e4d2 commit 957c595

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/integration/integration_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,10 +1541,10 @@ func TestSkipNotExistsTable(t *testing.T) {
15411541
pauseChannel <- pause / i
15421542
}
15431543
startTime := time.Now()
1544-
out, err := env.DockerExecOut("clickhouse-backup", "bash", "-ce", "LOG_LEVEL=debug CLICKHOUSE_BACKUP_CONFIG=/etc/clickhouse-backup/config-s3.yml clickhouse-backup create --table freeze_not_exists.freeze_not_exists "+testBackupName)
1544+
out, execErr := env.DockerExecOut("clickhouse-backup", "bash", "-ce", "LOG_LEVEL=debug CLICKHOUSE_BACKUP_CONFIG=/etc/clickhouse-backup/config-s3.yml clickhouse-backup create --table freeze_not_exists.freeze_not_exists "+testBackupName)
15451545
log.Debug().Msg(out)
1546-
if (err != nil && (strings.Contains(out, "can't freeze") || strings.Contains(out, "no tables for backup"))) ||
1547-
(err == nil && !strings.Contains(out, "can't freeze")) {
1546+
if (execErr != nil && (strings.Contains(out, "can't freeze") || strings.Contains(out, "no tables for backup"))) ||
1547+
(execErr == nil && !strings.Contains(out, "can't freeze")) {
15481548
parseTime := func(line string) time.Time {
15491549
parsedTime, err := time.Parse("2006-01-02 15:04:05.999", line[:23])
15501550
if err != nil {
@@ -1567,22 +1567,22 @@ func TestSkipNotExistsTable(t *testing.T) {
15671567
}
15681568
pause += (firstTime.Sub(startTime) + freezeTime.Sub(firstTime)).Nanoseconds()
15691569
}
1570-
if err != nil {
1570+
if execErr != nil {
15711571
if !strings.Contains(out, "no tables for backup") && !strings.Contains(out, "code: 473, message: Possible deadlock avoided") {
1572-
assert.NoError(t, err)
1572+
assert.NoError(t, execErr, "%s", out)
15731573
}
15741574
}
15751575

1576-
if strings.Contains(out, "code: 60") && err == nil {
1576+
if strings.Contains(out, "code: 60") && execErr == nil {
15771577
freezeErrorHandled = true
15781578
log.Debug().Msg("CODE 60 caught")
15791579
<-resumeChannel
15801580
env.DockerExecNoError(r, "clickhouse-backup", "bash", "-ec", "CLICKHOUSE_BACKUP_CONFIG=/etc/clickhouse-backup/config-s3.yml clickhouse-backup delete local "+testBackupName)
15811581
break
15821582
}
1583-
if err == nil {
1584-
err = env.DockerExec("clickhouse-backup", "bash", "-ec", "CLICKHOUSE_BACKUP_CONFIG=/etc/clickhouse-backup/config-s3.yml clickhouse-backup delete local "+testBackupName)
1585-
assert.NoError(t, err)
1583+
if execErr == nil {
1584+
execErr = env.DockerExec("clickhouse-backup", "bash", "-ec", "CLICKHOUSE_BACKUP_CONFIG=/etc/clickhouse-backup/config-s3.yml clickhouse-backup delete local "+testBackupName)
1585+
assert.NoError(t, execErr)
15861586
}
15871587
<-resumeChannel
15881588
}

0 commit comments

Comments
 (0)