Skip to content

Commit e7f06fa

Browse files
committed
fix wrong definition of view for 25.8, properly cleanup TestNamedCollections, fix #961
Signed-off-by: Slach <[email protected]>
1 parent 095e5ed commit e7f06fa

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/integration/integration_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2126,7 +2126,7 @@ func TestSkipTablesAndSkipTableEngines(t *testing.T) {
21262126
env.queryWithNoError(r, "CREATE DATABASE test_skip_tables")
21272127
env.queryWithNoError(r, "CREATE TABLE IF NOT EXISTS test_skip_tables.test_merge_tree (id UInt64, s String) ENGINE=MergeTree() ORDER BY id")
21282128
env.queryWithNoError(r, "CREATE TABLE IF NOT EXISTS test_skip_tables.test_memory (id UInt64) ENGINE=Memory")
2129-
env.queryWithNoError(r, "CREATE MATERIALIZED VIEW IF NOT EXISTS test_skip_tables.test_mv (id UInt64) ENGINE=MergeTree() ORDER BY id AS SELECT * FROM test_skip_tables.test_merge_tree")
2129+
env.queryWithNoError(r, "CREATE MATERIALIZED VIEW IF NOT EXISTS test_skip_tables.test_mv (id UInt64) ENGINE=MergeTree() ORDER BY id AS SELECT id FROM test_skip_tables.test_merge_tree")
21302130
if compareVersion(os.Getenv("CLICKHOUSE_VERSION"), "21.3") >= 0 {
21312131
query := "CREATE LIVE VIEW IF NOT EXISTS test_skip_tables.test_live_view AS SELECT count() FROM test_skip_tables.test_merge_tree"
21322132
allowExperimentalAnalyzer, err := env.ch.TurnAnalyzerOffIfNecessary(version, query, "")
@@ -3521,7 +3521,8 @@ func TestNamedCollections(t *testing.T) {
35213521
r.NoError(env.dropDatabase("test_named_collection", true))
35223522
})
35233523
}
3524-
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/test_named_collection.csv*")
3524+
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/test_named_collection.csv")
3525+
env.checkObjectStorageIsEmpty(t, r, "S3")
35253526
env.Cleanup(t, r)
35263527
}
35273528

0 commit comments

Comments
 (0)