dev: unbound settings and user settings

Author: sunsingerus

pkg/apis/clickhouse.altinity.com/v1/type_settings.go

@@ -80,12 +80,30 @@ func (s *Settings) ensureConverter() SettingsName2KeyConverter {
 		// Just return converter
 		return NewSettingsName2KeyConverterPlain()
 	}
-	if s.converter == nil {
-		s.converter = NewSettingsName2KeyConverterPlain()
+	if !s.HasConverter() {
+		s.SetConverter(NewSettingsName2KeyConverterPlain())
+	}
+	return s.GetConverter()
+}
+
+func (s *Settings) SetConverter(converter SettingsName2KeyConverter) *Settings {
+	if s != nil {
+		s.converter = converter
+	}
+	return s
+}
+
+func (s *Settings) GetConverter() SettingsName2KeyConverter {
+	if s == nil {
+		return nil
 	}
 	return s.converter
 }
 
+func (s *Settings) HasConverter() bool {
+	return s.GetConverter() != nil
+}
+
 // Ensure ensures settings are in place
 func (s *Settings) Ensure() *Settings {
 	if s == nil {

pkg/apis/clickhouse.altinity.com/v1/type_settings_user.go

@@ -26,7 +26,7 @@ func NewSettingsUser(settings *Settings, username string) *SettingsUser {
 		Settings: *settings,
 		username: username,
 	}
-	s.converter = NewSettingsName2KeyConverterPrefix(username)
+	s.Settings.SetConverter(NewSettingsName2KeyConverterPrefix(username))
 	return s
 }