ice: Add --s3-region CLI option

Author: shyiko

examples/scratch/README.md

@@ -46,10 +46,8 @@ ice insert --partition='[{"column": "tpep_pickup_datetime", "transform": "day"}]
 ice insert --partition='[{"column": "tpep_pickup_datetime", "transform": "year"}]' nyc44.taxis111 -p https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2025-01.parquet
 
 # warning: each parquet file below is ~500mb. this may take a while
-AWS_REGION=us-east-2 ice insert btc.transactions -p --s3-no-sign-request \
-  s3://aws-public-blockchain/v1.0/btc/transactions/\
-date=2025-01-01/part-00000-33e8d075-2099-409b-a806-68dd17217d39-c000.snappy.parquet \
-  s3://aws-public-blockchain/v1.0/btc/transactions/date=2025-01-02/*.parquet
+ice insert btc.transactions -p --s3-region=us-east-2 --s3-no-sign-request \
+  s3://aws-public-blockchain/v1.0/btc/transactions/date=2025-01-01/*.parquet
 
 # upload file to minio using local-mc,
 # then add file to the catalog without making a copy

ice/src/main/java/com/altinity/ice/cli/Main.java

@@ -141,9 +141,10 @@ void createTable(
               names = {"-p"},
               description = "Create table if not exists")
           boolean createTableIfNotExists,
+      @CommandLine.Option(names = {"--s3-region"}) String s3Region,
       @CommandLine.Option(
               names = {"--s3-no-sign-request"},
-              description = "Access input file(s) ")
+              description = "Access input file(s)")
           boolean s3NoSignRequest,
       @CommandLine.Option(
               arity = "1",
@@ -163,6 +164,7 @@ void createTable(
                   "JSON array of sort orders: [{\"column\":\"name\",\"desc\":true,\"nullFirst\":true}]")
           String sortOrderJson)
       throws IOException {
+    setAWSRegion(s3Region);
     try (RESTCatalog catalog = loadCatalog(this.configFile())) {
       List<IceSortOrder> sortOrders = new ArrayList<>();
       List<IcePartition> partitions = new ArrayList<>();
@@ -223,9 +225,10 @@ void insert(
               description =
                   "Use table credentials to access input files (instead of credentials from execution environment)")
           boolean forceTableAuth,
+      @CommandLine.Option(names = {"--s3-region"}) String s3Region,
       @CommandLine.Option(
               names = {"--s3-no-sign-request"},
-              description = "Access input file(s) ")
+              description = "Access input file(s)")
           boolean s3NoSignRequest,
       @CommandLine.Option(
               names = "--s3-copy-object",
@@ -269,6 +272,7 @@ void insert(
       throw new UnsupportedOperationException(
           "--s3-no-sign-request + --s3-copy-object is not supported by AWS (see --help for details)");
     }
+    setAWSRegion(s3Region);
     try (RESTCatalog catalog = loadCatalog(this.configFile())) {
       if (dataFiles.length == 1 && "-".equals(dataFiles[0])) {
         dataFiles = readInput().toArray(new String[0]);
@@ -326,6 +330,13 @@ void insert(
     }
   }
 
+  // FIXME: do not modify system properties, configure aws sdk instead
+  private static void setAWSRegion(String v) {
+    if (!Strings.isNullOrEmpty(v)) {
+      System.setProperty("aws.region", v);
+    }
+  }
+
   private static List<String> readInput() {
     List<String> r = new ArrayList<>();
     try (Scanner scanner = new Scanner(System.in)) {