Fix ice delete --dry-run

Author: shyiko

ice/src/main/java/com/altinity/ice/cli/Main.java

@@ -493,10 +493,14 @@ void delete(
           String partitionJson,
       @CommandLine.Option(
               names = "--dry-run",
-              description = "Log files that would be deleted without actually deleting them",
-              defaultValue = "true")
-          boolean dryRun)
+              description =
+                  "Log files that would be deleted without actually deleting them (true by default)")
+          Boolean dryRun)
       throws IOException {
+    if (dryRun == null) {
+      dryRun = true;
+    }
+
     try (RESTCatalog catalog = loadCatalog(this.configFile())) {
       List<PartitionFilter> partitions = new ArrayList<>();
       if (partitionJson != null && !partitionJson.isEmpty()) {

ice/src/main/java/com/altinity/ice/cli/internal/cmd/Delete.java

@@ -62,20 +62,17 @@ public static void run(
 
     if (!filesToDelete.isEmpty()) {
       if (dryRun) {
-        logger.info("Dry run: The following files would be deleted:");
         for (DataFile file : filesToDelete) {
-          logger.info("  {}", file.path());
+          logger.info("To be deleted: {}", file.location());
         }
       } else {
         RewriteFiles rewrite = table.newRewrite();
         for (DataFile deleteFile : filesToDelete) {
+          logger.info("Deleting {}", deleteFile.location());
           rewrite.deleteFile(deleteFile);
         }
         rewrite.commit();
-        logger.info("Partition(s) deleted.");
       }
-    } else {
-      logger.info("No files found for the partition(s).");
     }
   }
 }