Renamed metrics as it collides with prometheus reserved names.

Author: subkanthi

examples/grafana/iceberg-metrics-dashboard.json

@@ -3868,7 +3868,7 @@
             "type": "prometheus",
             "uid": "${datasource}"
           },
-          "expr": "sum by (table) (rate(ice_maintenance_compaction_files_created_total[$__rate_interval]))",
+          "expr": "sum by (table) (rate(ice_maintenance_compaction_output_files_total[$__rate_interval]))",
           "legendFormat": "Created - {{table}}",
           "refId": "B"
         }

ice-rest-catalog/src/main/java/com/altinity/ice/rest/catalog/internal/maintenance/DataCompaction.java

@@ -262,7 +262,7 @@ private void merge(
 
     // Record metrics after successful commit
     maintenanceMetrics.recordCompactionFilesMerged(tableName, dataFiles.size());
-    maintenanceMetrics.recordCompactionFileCreated(tableName);
+    maintenanceMetrics.recordCompactionOutputFile(tableName);
     maintenanceMetrics.recordCompactionBytesWritten(tableName, dataFileSizeInBytes);
   }
 }

ice-rest-catalog/src/main/java/com/altinity/ice/rest/catalog/internal/maintenance/MaintenanceScheduler.java

@@ -75,18 +75,20 @@ private void scheduleNextMaintenance() {
   }
 
   public void performMaintenance() {
-    MaintenanceMetrics metrics = MaintenanceMetrics.getInstance();
-
-    if (isMaintenanceMode.get()) {
-      logger.info("Skipping maintenance task as system is already in maintenance mode");
-      metrics.recordMaintenanceSkipped();
-      return;
-    }
 
     long startTime = System.nanoTime();
     boolean success = false;
-
+    MaintenanceMetrics metrics = null;
     try {
+
+      metrics = MaintenanceMetrics.getInstance();
+
+      if (isMaintenanceMode.get()) {
+        logger.info("Skipping maintenance task as system is already in maintenance mode");
+        metrics.recordMaintenanceSkipped();
+        return;
+      }
+
       logger.info("Starting scheduled maintenance task");
       setMaintenanceMode(true);
       metrics.recordMaintenanceStarted();
@@ -100,7 +102,9 @@ public void performMaintenance() {
     } finally {
       setMaintenanceMode(false);
       double durationSecs = (System.nanoTime() - startTime) / 1_000_000_000.0;
-      metrics.recordMaintenanceCompleted(success, durationSecs);
+      if (metrics != null) {
+        metrics.recordMaintenanceCompleted(success, durationSecs);
+      }
     }
   }
 

ice-rest-catalog/src/main/java/com/altinity/ice/rest/catalog/internal/metrics/MaintenanceMetrics.java

@@ -74,10 +74,10 @@ public class MaintenanceMetrics {
       "ice_maintenance_compaction_files_merged_total";
   private static final String COMPACTION_FILES_MERGED_TOTAL_HELP = "Total input files merged";
 
-  private static final String COMPACTION_FILES_CREATED_TOTAL_NAME =
-      "ice_maintenance_compaction_files_created_total";
-  private static final String COMPACTION_FILES_CREATED_TOTAL_HELP =
-      "Total output files created after merge";
+  private static final String COMPACTION_OUTPUT_FILES_TOTAL_NAME =
+      "ice_maintenance_compaction_output_files_total";
+  private static final String COMPACTION_OUTPUT_FILES_TOTAL_HELP =
+      "Total output files produced after merge";
 
   private static final String COMPACTION_BYTES_READ_TOTAL_NAME =
       "ice_maintenance_compaction_bytes_read_total";
@@ -108,7 +108,7 @@ public class MaintenanceMetrics {
 
   // Data Compaction
   private final Counter compactionFilesMergedTotal;
-  private final Counter compactionFilesCreatedTotal;
+  private final Counter compactionOutputFilesTotal;
   private final Counter compactionBytesReadTotal;
   private final Counter compactionBytesWrittenTotal;
 
@@ -189,10 +189,10 @@ private MaintenanceMetrics() {
             .labelNames(LABEL_TABLE)
             .register();
 
-    this.compactionFilesCreatedTotal =
+    this.compactionOutputFilesTotal =
         Counter.builder()
-            .name(COMPACTION_FILES_CREATED_TOTAL_NAME)
-            .help(COMPACTION_FILES_CREATED_TOTAL_HELP)
+            .name(COMPACTION_OUTPUT_FILES_TOTAL_NAME)
+            .help(COMPACTION_OUTPUT_FILES_TOTAL_HELP)
             .labelNames(LABEL_TABLE)
             .register();
 
@@ -249,8 +249,8 @@ public void recordCompactionFilesMerged(String table, int count) {
     compactionFilesMergedTotal.labelValues(table).inc(count);
   }
 
-  public void recordCompactionFileCreated(String table) {
-    compactionFilesCreatedTotal.labelValues(table).inc();
+  public void recordCompactionOutputFile(String table) {
+    compactionOutputFilesTotal.labelValues(table).inc();
   }
 
   public void recordCompactionBytesRead(String table, long bytes) {