Follow up to #24

shyiko · shyiko · commit 580e3187529e · 2025-05-12T00:15:15.000-07:00
ice insert: Fix race condition resulting from multiple threads using retryLog.add() without proper synchronization.
diff --git a/ice/src/main/java/com/altinity/ice/cli/internal/retry/RetryLog.java b/ice/src/main/java/com/altinity/ice/cli/internal/retry/RetryLog.java
@@ -28,8 +28,10 @@ public RetryLog(String f) throws IOException {
     this.w = new BufferedWriter(new FileWriter(f + "~"));
   }
 
+  // This method is expected to be thread-safe.
   public void add(String fileToRetry) throws IOException {
-    w.append(fileToRetry).write("\n");
+    //noinspection StringConcatenationInsideStringBufferAppend
+    w.append(fileToRetry + "\n");
   }
 
   public void commit() throws IOException {

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,10 @@ public RetryLog(String f) throws IOException {`
`28`	`28`	`this.w = new BufferedWriter(new FileWriter(f + "~"));`
`29`	`29`	`}`
`30`	`30`
	`31`	`+ // This method is expected to be thread-safe.`
`31`	`32`	`public void add(String fileToRetry) throws IOException {`
`32`		`- w.append(fileToRetry).write("\n");`
	`33`	`+ //noinspection StringConcatenationInsideStringBufferAppend`
	`34`	`+ w.append(fileToRetry + "\n");`
`33`	`35`	`}`
`34`	`36`
`35`	`37`	`public void commit() throws IOException {`