Enable migration of self-identified users (#1756)

* Enable migration of self-identified users

* Remove no longer relevant tests

---------

Co-authored-by: Ceredron <roar.mjelde@digdir.no>

Author: Ceredron

Test/Altinn.Correspondence.Tests/TestingController/Migration/MigrationControllerTests.cs

@@ -246,43 +246,6 @@ public async Task MakeCorrespondenceAvailable()
         Assert.True(respExt.Statuses.First().Ok);
     }
 
-    [Fact]
-    public async Task MakeCorrespondenceAvailable_SelfIdentfied_Rejected()
-    {
-        MigrateCorrespondenceExt migrateCorrespondenceExt = new MigrateCorrespondenceBuilder()
-            .CreateMigrateCorrespondence()
-            .WithRecipient(_selfIdentifedPartyUuidUrn)
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Read, new DateTime(2024, 1, 6, 11, 10, 21))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Read, new DateTime(2024, 1, 7, 15, 11, 56))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Read, new DateTime(2024, 1, 8, 14, 19, 22))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Confirmed, new DateTime(2024, 1, 8, 14, 20, 5))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Archived, new DateTime(2024, 1, 9, 10, 50, 17))
-            .Build();
-        SetNotificationHistory(migrateCorrespondenceExt);
-
-        CorrespondenceMigrationStatusExt resultObj = await MigrateSingleCorrespondence(migrateCorrespondenceExt);
-        Assert.NotNull(resultObj);
-
-        MakeCorrespondenceAvailableRequestExt request = new MakeCorrespondenceAvailableRequestExt()
-        {
-            CreateEvents = false,
-            CorrespondenceIds = [resultObj.CorrespondenceId],
-            CorrespondenceId = resultObj.CorrespondenceId
-        };
-        var makeAvailableResponse = await _migrationClient.PostAsJsonAsync(makeAvailableUrl, request);
-        Assert.True(makeAvailableResponse.IsSuccessStatusCode);
-        MakeCorrespondenceAvailableResponseExt respExt = await makeAvailableResponse.Content.ReadFromJsonAsync<MakeCorrespondenceAvailableResponseExt>();
-        Assert.NotNull(respExt);
-        Assert.NotNull(respExt.Statuses);
-        Assert.Equal(1, respExt.Statuses.Count);
-        Assert.Equal(resultObj.CorrespondenceId, respExt.Statuses.First().CorrespondenceId);
-        Assert.False(respExt.Statuses.First().Ok);
-
-        // Verify that correspondence still has IsMigrating set to true, which means we cannot retrieve it through GetOverview.
-        var getCorrespondenceOverviewResponse = await _recipientClient.GetAsync($"correspondence/api/v1/correspondence/{resultObj.CorrespondenceId}/content");
-        Assert.False(getCorrespondenceOverviewResponse.IsSuccessStatusCode);
-    }
-
     [Fact]
     public async Task MakeCorrespondenceAvailable_Defined()
     {
@@ -405,33 +368,6 @@ public async Task MakeCorrespondenceAvailable_SoftDeleted_OnCall()
         Assert.NotNull(resultObj.DialogId);
     }
 
-    [Fact]
-    public async Task MakeCorrespondenceAvailable_OnCall_SelfIdentified_NotMadeAvailable()
-    {
-        MigrateCorrespondenceExt migrateCorrespondenceExt = new MigrateCorrespondenceBuilder()
-            .CreateMigrateCorrespondence()
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Read, new DateTime(2024, 1, 12, 14, 20, 11))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Confirmed, new DateTime(2024, 1, 12, 14, 21, 05))
-            .WithStatusEvent(MigrateCorrespondenceStatusExt.Archived, new DateTime(2024, 1, 22, 09, 55, 20))
-            .WithCreatedAt(new DateTime(2024, 1, 1, 03, 09, 21))
-            .WithRecipient(_selfIdentifedPartyUuidUrn)
-            .WithResourceId("skd-migratedcorrespondence-5229-1")
-            .Build();
-        SetNotificationHistory(migrateCorrespondenceExt);
-
-        migrateCorrespondenceExt.MakeAvailable = true;
-
-        var initializeCorrespondenceResponse = await _migrationClient.PostAsJsonAsync(migrateCorrespondenceUrl, migrateCorrespondenceExt);
-        string result = await initializeCorrespondenceResponse.Content.ReadAsStringAsync();
-        Assert.True(initializeCorrespondenceResponse.IsSuccessStatusCode, result);
-        CorrespondenceMigrationStatusExt resultObj = JsonConvert.DeserializeObject<CorrespondenceMigrationStatusExt>(result);
-        Assert.True(String.IsNullOrEmpty(resultObj.DialogId));
-
-        // Verify that correspondence has IsMigrating set to true, which means we cannot retrieve it through GetOverview.
-        var getCorrespondenceOverviewResponse = await _recipientClient.GetAsync($"correspondence/api/v1/correspondence/{resultObj.CorrespondenceId}/content");
-        Assert.False(getCorrespondenceOverviewResponse.IsSuccessStatusCode);
-    }
-
     [Fact]
     public async Task MakeCorrespondenceAvailable_Multiple()
     {

Test/Altinn.Correspondence.Tests/TestingHandler/MigrateCorrespondenceHandlerTests.cs

@@ -233,39 +233,6 @@ public async Task MakeCorrespondenceAvailable_WithCorrespondenceId_Correspondenc
             _dialogportenServiceMock.VerifyNoOtherCalls();
         }
 
-        [Fact]
-        public async Task MakeCorrespondenceAvailable_WithCorrespondenceId_CorrespondenceBelongsToSelfIdentifiedRecipient_ShouldNotMakeAvailable()
-        {
-            // Arrange
-            var correspondenceId = Guid.NewGuid();
-            var request = new MakeCorrespondenceAvailableRequest
-            {
-                CorrespondenceId = correspondenceId,
-                CreateEvents = true
-            };
-
-            var mockCorrespondence = CreateMockCorrespondence(correspondenceId);
-            mockCorrespondence.Recipient = "urn:altinn:party:uuid:96B337F1-05EB-4DF0-A83A-165C14558153";
-
-            _correspondenceRepositoryMock.Setup(x => x.GetCorrespondenceById(
-                correspondenceId, It.IsAny<bool>(), It.IsAny<bool>(), It.IsAny<bool>(), It.IsAny<CancellationToken>(), It.IsAny<bool>()))
-                .ReturnsAsync(mockCorrespondence);
-
-            // Act
-            var result = await _handler.MakeCorrespondenceAvailable(request, CancellationToken.None);
-
-            // Assert
-            Assert.NotNull(result);
-            Assert.True(result.IsT0);
-            var response = result.AsT0;
-            Assert.NotNull(response.Statuses);
-            Assert.Single(response.Statuses);
-            Assert.Equal(correspondenceId, response.Statuses[0].CorrespondenceId);
-            Assert.False(response.Statuses[0].Ok);
-
-            _dialogportenServiceMock.VerifyNoOtherCalls();
-        }
-
         [Fact]
         public async Task MakeCorrespondenceAvailable_WithCorrespondenceIds_ShouldProcessMultipleCorrespondences()
         {

src/Altinn.Correspondence.Application/MigrateCorrespondence/MigrateCorrespondenceHandler.cs

@@ -271,11 +271,6 @@ public async Task<string> MakeCorrespondenceAvailableInDialogportenAndApi(Guid c
         {
             throw new InvalidOperationException($"Correspondence with id {correspondenceId} is purged and cannot be made available in Dialogporten or API");
         }
-        
-        if(!string.IsNullOrEmpty(correspondence.Recipient) && correspondence.Recipient.IsWithPartyUuidPrefix())
-        {
-            throw new InvalidOperationException($"Correspondence with id {correspondenceId} has a Self-Identifed user as recipient and cannot be made available in Dialogporten");
-        }
 
         // If the correspondence was soft deleted in Altinn 2, we need to pass this forward in order to set the system label correctly on the Dialog
         bool isSoftDeleted = await correspondenceMigrationEventHelper.IsCorrespondenceSoftDeleted(correspondence, cancellationToken);