Add changes based on feedback

Author: Espen Gulbrandsen

src/Events.Functions/Clients/EventsClient.cs

@@ -147,7 +147,7 @@ public async Task LogWebhookHttpStatusCode(CloudEventEnvelope cloudEventEnvelope
                 StatusCode = statusCode,
             };
 
-            StringContent httpContent = new(JsonSerializer.Serialize(logEntryData), Encoding.UTF8, "application/cloudevents+json");
+            StringContent httpContent = new(JsonSerializer.Serialize(logEntryData), Encoding.UTF8, "application/json");
             var accessToken = await GenerateAccessToken();
 
             await _client.PostAsync(endpoint, httpContent, accessToken);

src/Events.Functions/Constants/EventConstants.cs

@@ -1,13 +1,12 @@
-namespace Altinn.Platform.Events.Functions.Constants
+namespace Altinn.Platform.Events.Functions.Constants;
+
+/// <summary>
+/// Shared constants for Events.Functions project
+/// </summary>
+public static class EventConstants
 {
     /// <summary>
-    /// Shared constants for Events.Functions project
+    /// The cloud event type for subscription validation
     /// </summary>
-    public static class EventConstants
-    {
-        /// <summary>
-        /// The cloud event type for subscription validation
-        /// </summary>
-        public static string ValidationType => "platform.events.validatesubscription";
-    }
+    public const string ValidationType = "platform.events.validatesubscription";
 }

src/Events.Functions/EventsOutbound.cs

@@ -1,6 +1,5 @@
 using System.Threading.Tasks;
 
-using Altinn.Platform.Events.Functions.Clients.Interfaces;
 using Altinn.Platform.Events.Functions.Models;
 using Altinn.Platform.Events.Functions.Services.Interfaces;
 

src/Events.Functions/Models/LogEntryDto.cs

@@ -1,10 +1,6 @@
 using System;
 using System.Net;
 
-using Altinn.Platform.Events.Models;
-
-using CloudNative.CloudEvents;
-
 namespace Altinn.Platform.Events.Functions.Models
 {
     /// <summary>
@@ -13,32 +9,32 @@ namespace Altinn.Platform.Events.Functions.Models
     public record LogEntryDto
     {
         /// <summary>
-        /// The cloud event id associated with the logged event <see cref="CloudEvent"/>"/>
+        /// The cloud event id associated with the logged event
         /// </summary>
         public string CloudEventId { get; set; }
 
         /// <summary>
-        /// The resource associated with the cloud event <see cref="CloudEvent"/>
+        /// The resource associated with the cloud event 
         /// </summary>
         public string CloudEventResource { get; set; }
 
         /// <summary>
-        /// The type associated with the logged event <see cref="CloudEvent"/>
+        /// The type associated with the logged event 
         /// </summary>
         public string CloudEventType { get; set; }
 
         /// <summary>
-        /// The subscription id associated with the post action. <see cref="Subscription"/>"/>
+        /// The subscription id associated with the post action.
         /// </summary>
         public int SubscriptionId { get; set; }
 
         /// <summary>
-        /// The consumer of the event <see cref="Subscription"/>
+        /// The consumer of the event 
         /// </summary>
         public string Consumer { get; set; }
 
         /// <summary>
-        /// The consumers webhook endpoint <see cref="Subscription"/>
+        /// The consumers webhook endpoint
         /// </summary>
         public Uri Endpoint { get; set; }
 

src/Events.Functions/Services/Interfaces/IWebhookService.cs

@@ -1,19 +1,17 @@
-using System.Net.Http;
 using System.Threading.Tasks;
 
 using Altinn.Platform.Events.Functions.Models;
 
-namespace Altinn.Platform.Events.Functions.Services.Interfaces
+namespace Altinn.Platform.Events.Functions.Services.Interfaces;
+
+/// <summary>
+/// Interface to send content to webhooks
+/// </summary>
+public interface IWebhookService
 {
     /// <summary>
-    /// Interface to send content to webhooks
+    /// Send cloudevent to webhook
     /// </summary>
-    public interface IWebhookService
-    {
-        /// <summary>
-        /// Send cloudevent to webhook
-        /// </summary>
-        /// <param name="envelope">CloudEventEnvelope, includes content and uri</param>
-        Task Send(CloudEventEnvelope envelope);
-    }
+    /// <param name="envelope">CloudEventEnvelope, includes content and uri</param>
+    Task Send(CloudEventEnvelope envelope);
 }

src/Events.Functions/Services/WebhookService.cs

@@ -43,7 +43,7 @@ public async Task Send(CloudEventEnvelope envelope)
             {
                 HttpResponseMessage response = await _client.PostAsync(envelope.Endpoint, httpContent);
 
-                // log response from webhook to storage
+                // log response from webhook to Events
                 await _eventsClient.LogWebhookHttpStatusCode(envelope, response.StatusCode);
 
                 if (!response.IsSuccessStatusCode)

src/Events/Services/Interfaces/ITraceLogService.cs

@@ -1,39 +1,36 @@
-using System;
-using System.Net;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 using Altinn.Platform.Events.Models;
 
 using CloudNative.CloudEvents;
 
-namespace Altinn.Platform.Events.Services.Interfaces
+namespace Altinn.Platform.Events.Services.Interfaces;
+
+/// <summary>
+/// Interface for trace log service.
+/// </summary>
+public interface ITraceLogService
 {
     /// <summary>
-    /// Interface for trace log service.
+    /// Creates a trace log entry based on registration of a new event
     /// </summary>
-    public interface ITraceLogService
-    {
-        /// <summary>
-        /// Creates a trace log entry based on registration of a new event
-        /// </summary>
-        /// <param name="cloudEvent">CloudNative CloudEvent <see cref="CloudEvent"/></param>
-        /// <returns>A <see cref="Task"/> representing the result of the asynchronous operation: Cloud event id.</returns>
-        Task<string> CreateRegisteredEntry(CloudEvent cloudEvent);
+    /// <param name="cloudEvent">CloudNative CloudEvent <see cref="CloudEvent"/></param>
+    /// <returns>A <see cref="Task"/> representing the result of the asynchronous operation: Cloud event id.</returns>
+    Task<string> CreateRegisteredEntry(CloudEvent cloudEvent);
 
-        /// <summary>
-        /// Log response from webhook post to subscriber.
-        /// </summary>
-        /// <param name="logEntryDto">Data transfer object associated with cloud event, status code, and subscription</param>
-        /// <returns>A string representation of the GUID or an empty string</returns>
-        Task<string> CreateWebhookResponseEntry(LogEntryDto logEntryDto);
+    /// <summary>
+    /// Log response from webhook post to subscriber.
+    /// </summary>
+    /// <param name="logEntryDto">Data transfer object associated with cloud event, status code, and subscription</param>
+    /// <returns>A string representation of the GUID or an empty string</returns>
+    Task<string> CreateWebhookResponseEntry(LogEntryDto logEntryDto);
 
-        /// <summary>
-        /// Creates a trace log entry with information about cloud event and subscription
-        /// </summary>
-        /// <param name="cloudEvent">Cloud Event associated with log entry <see cref="CloudEvent"/></param>
-        /// <param name="subscription">Subscription associated with log entry <see cref="Subscription"/></param>
-        /// <param name="activity">Type of activity associated with log entry <see cref="TraceLogActivity"/></param>
-        /// <returns>Returns empty string if a log entry can't be created</returns>
-        Task<string> CreateLogEntryWithSubscriptionDetails(CloudEvent cloudEvent, Subscription subscription, TraceLogActivity activity);
-    }
+    /// <summary>
+    /// Creates a trace log entry with information about cloud event and subscription
+    /// </summary>
+    /// <param name="cloudEvent">Cloud Event associated with log entry <see cref="CloudEvent"/></param>
+    /// <param name="subscription">Subscription associated with log entry <see cref="Subscription"/></param>
+    /// <param name="activity">Type of activity associated with log entry <see cref="TraceLogActivity"/></param>
+    /// <returns>Returns empty string if a log entry can't be created</returns>
+    Task<string> CreateLogEntryWithSubscriptionDetails(CloudEvent cloudEvent, Subscription subscription, TraceLogActivity activity);
 }