Add changes based on feedback

Author: Espen Gulbrandsen

src/Events.Functions/Models/LogEntryDto.cs

@@ -6,7 +6,7 @@ namespace Altinn.Platform.Events.Functions.Models
     /// <summary>
     /// Data transfer object for posting a log event after receiving a webhook response.
     /// </summary>
-    public record LogEntryDto
+    public class LogEntryDto
     {
         /// <summary>
         /// The cloud event id associated with the logged event

src/Events/Models/LogEntryDto.cs

@@ -9,7 +9,7 @@ namespace Altinn.Platform.Events.Models
     /// <summary>
     /// Data transfer object for posting a log event after receiving a webhook response.
     /// </summary>
-    public record LogEntryDto
+    public class LogEntryDto
     {
         /// <summary>
         /// The cloud event id associated with the logged event <see cref="CloudEvent"/>"/>

test/Altinn.Platform.Events.Functions.Tests/TestingClients/EventsClientTests.cs

@@ -87,11 +87,11 @@ public async Task PostLogEntry_SuccessResponse(string resource)
                 HttpStatusCode.OK);
 
             var sut = new EventsClient(
-            new HttpClient(handlerMock.Object),
-            _atgMock.Object,
-            _srMock.Object,
-            _platformSettings,
-            _loggerMock.Object);
+                new HttpClient(handlerMock.Object),
+                _atgMock.Object,
+                _srMock.Object,
+                _platformSettings,
+                _loggerMock.Object);
 
             _cloudEvent["resource"] = resource;
 
@@ -175,7 +175,7 @@ public async Task PostInbound_NonSuccessResponse_ErrorLoggedAndExceptionThrown()
                 It.IsAny<EventId>(),
                 It.Is<It.IsAnyType>((v, t) => v.ToString().Contains("PostInbound event with id 1337 failed with status code ServiceUnavailable")),
                 It.IsAny<Exception>(),
-                (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()), 
+                (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()),
                 Times.Once);
         }
 
@@ -220,7 +220,7 @@ public async Task PostOutbound_NonSuccessResponse_ErrorLoggedAndExceptionThrown(
                 It.IsAny<EventId>(),
                 It.Is<It.IsAnyType>((v, t) => v.ToString().Contains("PostOutbound event with id 1337 failed with status code ServiceUnavailable")),
                 It.IsAny<Exception>(),
-                (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()), 
+                (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()),
                 Times.Once);
         }
 

test/Altinn.Platform.Events.Functions.Tests/TestingFunctions/EventsOutboundTests.cs

@@ -1,4 +1,3 @@
-using Altinn.Platform.Events.Functions.Clients.Interfaces;
 using Altinn.Platform.Events.Functions.Models;
 using Altinn.Platform.Events.Functions.Services.Interfaces;
 
@@ -35,9 +34,8 @@ public async Task Run_ConfirmDeserializationOCloudEventEnvelope_CloudEventPersis
             Mock<IWebhookService> webhookServiceMock = new();
             webhookServiceMock.Setup(wh => wh.Send(It.Is<CloudEventEnvelope>(cee => cee.CloudEvent != null)))
                 .Callback<CloudEventEnvelope>(cee => actualServiceInput = cee)
-                .Returns(Task.FromResult(new HttpResponseMessage()));
+                .Returns(Task.CompletedTask);
 
-            Mock<IEventsClient> eventsClientMock = new();
             var sut = new EventsOutbound(webhookServiceMock.Object);
 
             // Act

test/Altinn.Platform.Events.Functions.Tests/TestingFunctions/SubscriptionValidationTests.cs

@@ -65,7 +65,7 @@ public async Task Run_SendWebhookSucceeds_ValidateSubscriptionCalled()
             // Arrange
             Mock<IWebhookService> webhookServiceMock = new();
             webhookServiceMock.Setup(wh => wh.Send(It.IsAny<CloudEventEnvelope>()))
-                .Returns(Task.FromResult(new HttpResponseMessage()));
+                .Returns(Task.CompletedTask);
 
             Mock<IEventsClient> clientMock = new();
 

test/Altinn.Platform.Events.Tests/Models/LogEntryData.cs

@@ -7,7 +7,7 @@ namespace Altinn.Platform.Events.Tests.Models
     /// <summary>
     /// Data transfer object for posting a log event after receiving a webhook response.
     /// </summary>
-    public record LogEntryData
+    public class LogEntryData
     {
         /// <summary>
         /// The cloud event associated with the post action <see cref="CloudEvent"/>"/>