Skip to content

Commit 1fbf27d

Browse files
authored
fix(subscription): remove guard to prevent updates within 500 ms window (#3793)
1 parent 7541203 commit 1fbf27d

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

packages/frontend/src/api/hooks/useDialogByIdSubscription.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export const useDialogByIdSubscription = (dialogId: string | undefined, dialogTo
3131
const { logError } = useErrorLogger();
3232

3333
const eventSourceRef = useRef<SSE | null>(null);
34-
const lastInvalidatedDate = useRef(new Date().toISOString());
3534
const isFirstRender = useRef(true);
3635
const onMessageRef = useRef<((eventData: DialogEventData, rawEvent: MessageEvent) => void) | undefined>(undefined);
3736

@@ -81,10 +80,6 @@ export const useDialogByIdSubscription = (dialogId: string | undefined, dialogTo
8180
try {
8281
const jsonPayload = JSON.parse(event.data);
8382
const updatedType: DialogEventType | undefined = jsonPayload.data?.dialogEvents?.type;
84-
const now = new Date().toISOString();
85-
const diff = new Date(now).getTime() - new Date(lastInvalidatedDate.current).getTime();
86-
if (diff <= 500) return;
87-
lastInvalidatedDate.current = now;
8883

8984
onMessageRef.current?.(jsonPayload, event);
9085
if (updatedType === DialogEventType.DialogDeleted) {

packages/frontend/tests/stories/savedSearch.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,11 @@ test.describe('Saved search', () => {
8484
await expect(savedSearchLink).toBeVisible();
8585

8686
await savedSearchLink.click();
87+
88+
await page.bringToFront();
89+
await page.click('body', { position: { x: 1, y: 1 } });
8790
await page.keyboard.press('Escape');
91+
8892
await expect(page.getByRole('link', { name: 'Innkalling til sesjon' })).toBeVisible();
8993
await expectIsCompanyPage(page);
9094
});

packages/frontend/tests/stories/sidebar.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ test.describe('Sidebar menu', () => {
1414
} else {
1515
await getSidebarMenuItem(page, PageRoutes.drafts).click();
1616
}
17-
await expect(page.getByRole('heading', { name: 'utkast' })).toBeVisible();
17+
await expect(page.getByRole('heading', { name: 'Utkast' })).toBeVisible();
1818

1919
if (isMobile) {
2020
await page.getByRole('button', { name: 'Meny' }).click();

0 commit comments

Comments
 (0)