feat: Add notifications page email and sms verification (#3684)

Author: mbacherycz

packages/bff-types-generated/queries/VerifyAddress.graphql

@@ -0,0 +1,6 @@
+mutation verifyAddress($data: VerifyAddressInput!) {
+  verifyAddress(data: $data) {
+    success
+    message
+  }
+}

packages/bff-types-generated/queries/notificationsettingForCurrentUser.fragment.graphql

@@ -4,4 +4,7 @@ fragment NotificationsettingForCurrentUserFields on NotificationSettingsResponse
   resourceIncludeList
   userId
   partyUuid
+  emailVerificationStatus
+  smsVerificationStatus
+  needsConfirmation
 }

packages/bff-types-generated/queries/verifiedAddresses.graphql

@@ -0,0 +1,6 @@
+query verifiedAddresses {
+  verifiedAddresses {
+    value
+    addressType
+  }
+}

packages/bff/src/graphql/functions/profile.ts

@@ -5,7 +5,7 @@ import config from '../../config.ts';
 import { GroupRepository, PartyRepository, ProfileRepository } from '../../db.ts';
 import { Group, Party, ProfileTable } from '../../entities.ts';
 import type { PreselectedPartyOperationType } from '../types/mutation.ts';
-import type { NotificationSettingsInputData } from '../types/profile.ts';
+import type { NotificationSettingsInputData, VerifyAddressInputData } from '../types/profile.ts';
 
 const { platformBaseURL } = config;
 
@@ -454,6 +454,56 @@ export const updateProfileSettingPreference = async (context: Context, shouldSho
   }
 };
 
+export const verifyAddress = async (data: VerifyAddressInputData, context: Context) => {
+  const newToken = await exchangeToken(context);
+  try {
+    await axios.post(
+      `${platformProfileAPI_url}users/current/verification/verify`,
+      { value: data.value, type: data.type, verificationCode: data.verificationCode },
+      {
+        timeout: 30000,
+        headers: {
+          Authorization: `Bearer ${newToken}`,
+          'Content-Type': 'application/json',
+          Accept: 'application/json',
+        },
+      },
+    );
+    return { success: true };
+  } catch (error) {
+    if (typeof error === 'object' && error !== null && 'response' in error) {
+      const axiosError = error as { response?: { status?: number } };
+      if (axiosError.response?.status === 422) {
+        return { success: false, message: 'invalid_code' };
+      }
+    }
+    logger.error(error, 'Error verifying address:');
+    throw error;
+  }
+};
+
+export const getVerifiedAddresses = async (context: Context) => {
+  const newToken = await exchangeToken(context);
+  if (!newToken) {
+    logger.error('No new token received');
+    throw new Error('Unable to exchange token');
+  }
+  try {
+    const response = await axios.get(`${platformProfileAPI_url}users/current/verification/verified-addresses`, {
+      timeout: 30000,
+      headers: {
+        Authorization: `Bearer ${newToken}`,
+        'Content-Type': 'application/json',
+        Accept: 'application/json',
+      },
+    });
+    return response.data ?? [];
+  } catch (error) {
+    logger.error(error, 'Error fetching verified addresses for user:');
+    return [];
+  }
+};
+
 export const updateLanguage = async (pid: string, language: string) => {
   const currentProfile = await ProfileRepository!.findOne({
     where: { pid },

packages/bff/src/graphql/types/mutation.ts

@@ -11,10 +11,11 @@ import {
   updateLanguage,
   updateNotificationsSetting,
   updateProfileSettingPreference,
+  verifyAddress,
 } from '../functions/profile.ts';
 import { createSavedSearch, deleteSavedSearch, updateSavedSearch } from '../functions/savedsearch.ts';
 import { languageCodes, updateAltinnPersistentContextValue } from './cookie.js';
-import { NotificationSettingsInput, Response, SavedSearchInput, SavedSearches } from './index.ts';
+import { NotificationSettingsInput, Response, SavedSearchInput, SavedSearches, VerifyAddressInput } from './index.ts';
 
 export const Mutation = extendType({
   type: 'Mutation',
@@ -256,6 +257,27 @@ export const UpdateProfileSettingPreference = extendType({
   },
 });
 
+export const VerifyAddress = extendType({
+  type: 'Mutation',
+  definition(t) {
+    t.field('verifyAddress', {
+      type: Response,
+      args: {
+        data: VerifyAddressInput,
+      },
+      resolve: async (_, { data }, ctx) => {
+        try {
+          const result = await verifyAddress(data, ctx);
+          return result;
+        } catch (error) {
+          logger.error(error, 'Failed to verify address:');
+          return { success: false, message: 'Failed to verify address' };
+        }
+      },
+    });
+  },
+});
+
 export type PreselectedPartyOperationType = 'set' | 'unset';
 export const SetPreSelectedParty = extendType({
   type: 'Mutation',

packages/bff/src/graphql/types/profile.ts

@@ -249,6 +249,18 @@ export const NotificationSettingsResponse = objectType({
       description: 'ID of the party',
       resolve: (obj) => obj.partyUuid,
     });
+    t.nullable.string('emailVerificationStatus', {
+      description: 'Verification status for the email address (Unverified, Verified, Legacy)',
+      resolve: (obj) => obj.emailVerificationStatus,
+    });
+    t.nullable.string('smsVerificationStatus', {
+      description: 'Verification status for the SMS/phone number (Unverified, Verified, Legacy)',
+      resolve: (obj) => obj.smsVerificationStatus,
+    });
+    t.nullable.boolean('needsConfirmation', {
+      description: 'Indicates whether the notification settings need confirmation',
+      resolve: (obj) => obj.needsConfirmation,
+    });
   },
 });
 
@@ -260,6 +272,7 @@ export const NotificationSettingsInput = inputObjectType({
     t.string('emailAddress');
     t.string('phoneNumber');
     t.list.string('resourceIncludeList');
+    t.nullable.boolean('generateVerificationCode');
   },
 });
 
@@ -269,6 +282,22 @@ export interface NotificationSettingsInputData {
   emailAddress?: string;
   phoneNumber?: string;
   resourceIncludeList?: string[];
+  generateVerificationCode?: boolean;
+}
+
+export const VerifyAddressInput = inputObjectType({
+  name: 'VerifyAddressInput',
+  definition(t) {
+    t.string('value');
+    t.string('type');
+    t.string('verificationCode');
+  },
+});
+
+export interface VerifyAddressInputData {
+  value: string;
+  type: 'Email' | 'Sms';
+  verificationCode: string;
 }
 
 export const ProfileSettingPreference = objectType({
@@ -284,6 +313,14 @@ export const ProfileSettingPreference = objectType({
   },
 });
 
+export const VerifiedAddressResponse = objectType({
+  name: 'VerifiedAddressResponse',
+  definition(t) {
+    t.nullable.string('value');
+    t.nullable.string('addressType', { resolve: (obj) => obj.type ?? null });
+  },
+});
+
 export const UserProfile = objectType({
   name: 'UserProfile',
   definition(t) {

packages/bff/src/graphql/types/query.ts

@@ -8,6 +8,7 @@ import {
   getNotificationsettingsForCurrentUser,
   getOrCreateProfile,
   getUserFromCore,
+  getVerifiedAddresses,
 } from '../functions/profile.ts';
 import { getLanguageFromAltinnContext, languageCodes, updateAltinnPersistentContextValue } from './cookie.js';
 import { getOrganizationsFromRedis } from './organization.ts';
@@ -94,6 +95,13 @@ export const Query = objectType({
       },
     });
 
+    t.field('verifiedAddresses', {
+      type: list('VerifiedAddressResponse'),
+      resolve: async (_source, _args, ctx) => {
+        return (await getVerifiedAddresses(ctx)) ?? [];
+      },
+    });
+
     t.field('getNotificationAddressByOrgNumber', {
       type: OrganizationResponse,
       args: {

packages/frontend/package.json

@@ -22,7 +22,7 @@
     "i18n:sort": "tsx ./src/i18n/check.ts --sort"
   },
   "dependencies": {
-    "@altinn/altinn-components": "0.56.23",
+    "@altinn/altinn-components": "0.56.24",
     "@microsoft/applicationinsights-react-js": "19.3.7",
     "@microsoft/applicationinsights-web": "3.3.9",
     "@navikt/aksel-icons": "^7.37.0",

packages/frontend/src/api/queries.ts

@@ -21,6 +21,9 @@ import {
   type UpdateProfileSettingPreferenceMutation,
   type UpdateSavedSearchMutation,
   type UpdateSystemLabelMutation,
+  type VerifiedAddressesQuery,
+  type VerifyAddressMutation,
+  type VerifyAddressMutationVariables,
   getSdk,
 } from 'bff-types-generated';
 import { ClientError, GraphQLClient, type RequestMiddleware, type ResponseMiddleware } from 'graphql-request';
@@ -237,3 +240,8 @@ export const updateProfileSettingPreference = (
   shouldShowDeletedEntities: boolean,
 ): Promise<UpdateProfileSettingPreferenceMutation> =>
   graphQLSDK.UpdateProfileSettingPreference({ shouldShowDeletedEntities });
+
+export const getVerifiedAddresses = (): Promise<VerifiedAddressesQuery> => graphQLSDK.verifiedAddresses();
+
+export const verifyAddress = (data: VerifyAddressMutationVariables['data']): Promise<VerifyAddressMutation> =>
+  graphQLSDK.verifyAddress({ data });

packages/frontend/src/constants/queryKeys.ts

@@ -29,4 +29,5 @@ export const QUERY_KEYS = {
   ALTINN_COOKIE: 'altinnCookie',
   UPDATED_LANGUAGE: 'updatedLanguage',
   SHOW_DELETED_ENTITIES: 'showDeletedEntities',
+  VERIFIED_ADDRESSES: 'verifiedAddresses',
 };