😡Ruff it up x5

Author: Aluerie

ext/alerts.py

@@ -158,7 +158,7 @@ async def bans_timeouts(self, ban: twitchio.Ban) -> None:
 
     @commands.Component.listener(name="subscription")
     async def subscription(self, subscribe: twitchio.ChannelSubscribe) -> None:
-        """Subscriptions"""
+        """Subscriptions."""
         await subscribe.broadcaster.send_message(
             sender=self.bot.bot_id,
             message=f"{subscribe.user.mention} just subscribed {const.STV.Donki} thanks",

ext/counters.py

@@ -132,7 +132,10 @@ async def first_counter(self, redemption: twitchio.ChannelPointsRedemptionAdd) -
         if count == 1:
             msg = f'@{redemption.user.display_name}, gratz on your very first "First!" {const.STV.gg}'
         else:
-            msg = f"@{redemption.user.display_name}, Gratz! you've been first {count} times {const.STV.gg} {const.Global.EZ}"
+            msg = (
+                f"@{redemption.user.display_name}, Gratz! you've been first {count} times"
+                f" {const.STV.gg} {const.Global.EZ}"
+            )
 
         await redemption.broadcaster.send_message(
             sender=self.bot.bot_id,

ext/dev.py

@@ -2,7 +2,6 @@
 
 import asyncio
 import logging
-import os
 from typing import TYPE_CHECKING, Annotated
 
 from twitchio.ext import commands
@@ -54,9 +53,9 @@ async def reboot(self, ctx: commands.Context) -> None:
         await asyncio.sleep(3)
         try:
             # non systemctl users - sorry
-            os.system("sudo systemctl restart luebot")
-        except Exception as error:
-            log.error(error, stack_info=True)
+            await asyncio.create_subprocess_shell("sudo systemctl restart luebot")  # `os.system`
+        except Exception:
+            log.exception("Failed to Restart the bot's process", stack_info=True)
             # it might not go off
             await ctx.send("Something went wrong.")
 

ext/management.py

@@ -181,12 +181,6 @@ async def title_history(self, ctx: commands.Context, number: int = 3) -> None:
     @commands.Component.listener(name="channel_update")
     async def channel_update(self, update: twitchio.ChannelUpdate) -> None:
         """Channel Info (game, title, etc) got updated."""
-        # payload: eventsub.ChannelUpdateData = event.data
-        # channel_name = payload.broadcaster.name
-        # assert channel_name
-        # channel = self.bot.get_channel(channel_name)
-        # assert channel
-
         now = datetime.datetime.now(datetime.UTC)
         # time check is needed so we don't repeat notif that comes from !game !title commands.
 

ext/simple_commands.py

@@ -308,8 +308,7 @@ async def charinfo(self, ctx: commands.Context, *, characters: str) -> None:
 
         def to_string(c: str) -> str:
             name = unicodedata.name(c, None)
-            name = f"\\N{{{name}}}" if name else "Name not found."
-            return name
+            return f"\\N{{{name}}}" if name else "Name not found."
 
         names = " ".join(to_string(c) for c in characters[:10])
         if len(characters) > 10:
@@ -318,6 +317,7 @@ def to_string(c: str) -> str:
 
     @commands.command(aliases=["id", "twitchid"])
     async def twitch_id(self, ctx: commands.Context, *, user: twitchio.User) -> None:
+        """Get mentioned @user numeric twitch_id."""
         await ctx.send(f"Twitch ID for {user.mention}: {user.id}")
 
 

utils/dota/dota2client.py

@@ -47,8 +47,8 @@ def aluerie(self) -> PartialUser:
 
     async def start_helpers(self) -> None:
         if not self.started:
-            await self.steam_web_api.__aenter__()
-            await self.stratz.__aenter__()
+            await self.steam_web_api.__aenter__()  # noqa: PLC2801
+            await self.stratz.__aenter__()  # noqa: PLC2801
             self.items.start()
 
     @override

utils/dota/pulsefire_clients.py

@@ -52,8 +52,8 @@ async def get_real_time_stats(self, server_steam_id: int) -> steam_web_api.RealT
 
         https://steamapi.xpaw.me/#IDOTA2MatchStats_570/GetRealtimeStats.
         """
-        queries = {"server_steam_id": server_steam_id}  # noqa F481
-        return await self.invoke("GET", "/IDOTA2MatchStats_570/GetRealtimeStats/v1/")  # type: ignore
+        queries = {"server_steam_id": server_steam_id}  # noqa: F841
+        return await self.invoke("GET", "/IDOTA2MatchStats_570/GetRealtimeStats/v1/")  # pyright: ignore[reportReturnType]
 
 
 class DotaAPIsRateLimiter(BaseRateLimiter):
@@ -196,5 +196,5 @@ async def get_items(self) -> stratz.ItemsResponse:
                 }
             }
         """
-        json = {"query": query}  # noqa F481
-        return await self.invoke("POST", "")  # type: ignore
+        json = {"query": query}  # noqa: F841
+        return await self.invoke("POST", "")  # pyright: ignore[reportReturnType]