|
| 1 | +### Community guidelines |
| 2 | + |
| 3 | + * Be respectful to others |
| 4 | + * Be appreciative and welcoming |
| 5 | + * Don't be judgmental |
| 6 | + * Be patient and supportive to newcomers |
| 7 | + * Value each contribution, even if it's not perfect - we can work as a team to benefit even from a failed attempt as we can learn from it! |
| 8 | + * Look after one another - we are community of like-minded people who care about others, not only about ticking the boxes |
| 9 | + * A challenge is not a bad thing, as it leads to expanding the horizons, being to competitive leads to unhealthy situations - be reasonable here |
| 10 | + |
| 11 | +### Code conventions |
| 12 | + |
| 13 | +Please try to match the current style. |
| 14 | + |
| 15 | +There is always room for opportunistic refactoring, but be careful and ensure the cosmetic changes have no adverse impact on performance or readability. |
| 16 | + |
| 17 | +### Testing conventions |
| 18 | + |
| 19 | +The project comes with unit tests. Make sure you pass all the existing tests locally before submitting the merge request. Furthermore, if you introduce something new and nontrivial, adding tests will help your change be merged. |
| 20 | + |
| 21 | +### Commit-message conventions |
| 22 | + |
| 23 | + * When relevant, add references to related ticket numbers in your commit message. |
| 24 | + * Make the commit messages meaningful. Don't skip them. They may be helpful during the code review and act as a passive documentation going forwards. |
| 25 | + |
| 26 | +### Steps for creating good pull requests |
| 27 | + |
| 28 | + * State your intent very clearly |
| 29 | + * If there is a need to provide a thorough explanation or refer to external sources, please do it - it will help in the review |
| 30 | + * If you are unsure about certain aspects, don't be scared of asking ahead of creating the PR. |
| 31 | + * If you are aware of some drawback of the changes introduced be transparent about it, the reviewers will weigh pros and cons and your contribution may still be accepted |
| 32 | + * It is okay to have several commits in your merge request, but each commit should be logically self-contained and there should not be any "fix-the-previous-commit" commit. |
| 33 | + * You can use the PR as a medium for the conversation between yourself and the project maintainers. You can prefix the PR with a meaningful tag eg. [IDEA], [SUGGESTION], [REMARK] etc. In such case your PR may never be integrated if what you are proposing is not in line with the general direction the project is going to. However, it would be still a valuable resource to track the discussion that took place and it may save time for somebody who is heading in a similar direction. |
| 34 | + |
| 35 | +### How to submit feature requests |
| 36 | + |
| 37 | + * You may want to discuss the feature with the maintainers in a ticket. |
| 38 | + * Use the GitHub Issues associated to this project |
| 39 | + * Link the PR (when the contribution is planned) with the Jira ticket/GitHub issue if possible - it may give us more context and will make the case for the change stronger |
| 40 | + * Please be thorough with the description |
| 41 | + |
| 42 | +### How to submit bug reports |
| 43 | + |
| 44 | + * Check carefully the documentaion and by asking on the available forums if the behaviour you are experiencing is expected or if it is a bug |
| 45 | + * Use Issues board associated to the project |
| 46 | + * Link the PR (when the contribution is planned) with the bug report request if possible - it may give us more context |
| 47 | + * Please be thorough with the description |
| 48 | + |
| 49 | +### How to submit security issue reports |
| 50 | + |
| 51 | +* Engage with project maintainers through email. Do not publicly disclose anything. |
| 52 | + |
| 53 | +### How to write documentation |
| 54 | + |
| 55 | + * Use [markdown syntax](https://www.markdownguide.org/basic-syntax/) which is widely supported in the GitHub, BitBucket WebUI as well as in many IDEs |
| 56 | + * Use plain English and check your spelling prior to committing the change |
| 57 | + * Remember that good documentation is essential, so take time to do it properly |
0 commit comments