Properly handle issues without a line number

See #197

Author: t-8ch

src/main/java/org/sonar/plugins/stash/issue/MarkdownPrinter.java

@@ -147,7 +147,13 @@ private String fileNameList(List<PostJobIssue> issues) {
     issues.sort(issueFormatComparator);
 
     for (PostJobIssue issue: issues.subList(0, Math.min(includeFilesInOverview, issues.size()))) {
-      names.add(String.format("%s:%s", issuePathResolver.getIssuePath(issue), issue.line()));
+      String path = issuePathResolver.getIssuePath(issue);
+      Integer line = issue.line();
+      if (line == null) {
+        names.add(path);
+      } else {
+        names.add(String.format("%s:%s", path, line));
+      }
     }
     if (issues.size() > includeFilesInOverview) {
       names.add("...");
@@ -171,13 +177,25 @@ private static String link(String title, String target) {
       .comparing(i -> issuePathResolver.getIssuePath(i).length());
 
   private Comparator<PostJobIssue> issueLine = Comparator
-      .comparing(PostJobIssue::line);
+      // -1 sorts before all issues with lines
+      .comparing(issue -> firstNonNull(issue.line(), -1));
 
   private Comparator<PostJobIssue> fileNameLexical = Comparator
       .comparing(i -> issuePathResolver.getIssuePath(i));
 
   private Comparator<PostJobIssue> issueFormatComparator =
       fileNameLength
       .thenComparing(issueLine)
-      .thenComparing(fileNameLexical);
+      .thenComparing(fileNameLexical)
+      ;
+
+  @SafeVarargs
+  private static <T> T firstNonNull(T... args) {
+    for (T t: args) {
+      if (t != null) {
+        return t;
+      }
+    }
+    throw new IllegalStateException("At least one of the arguments should have been non-null");
+  }
 }

src/test/java/org/sonar/plugins/stash/issue/MarkdownPrinterTest.java

@@ -157,6 +157,38 @@ public void testPrintReportMarkdownWithIssueLimitation() {
     assertEquals(reportString, issueReportMarkdown);
   }
 
+  @Test
+  public void testPrintReportMarkdownWithFileWideIssues() {
+    PostJobIssue issueWithoutLine = new DefaultIssue().setKey("key36")
+        .setSeverity(Severity.CRITICAL)
+        .setMessage("messageCritical")
+        .setRuleKey(RuleKey.of("RepoCritical", "RuleCritical"))
+        .setInputComponent(new DefaultInputFile("foo2", "scripts/file2.example"))
+        .setLine(null);
+    report.add(issueWithoutLine);
+    printer = new MarkdownPrinter(100, SONAR_URL, 100, new DummyIssuePathResolver());
+    String issueReportMarkdown = printer.printReportMarkdown(report);
+    String reportString = "## SonarQube analysis Overview\n"
+        + "| Total New Issues | 6 |\n"
+        + "|-----------------|------|\n"
+        + "| BLOCKER | 1 |\n"
+        + "| CRITICAL | 2 |\n"
+        + "| MAJOR | 3 |\n"
+        + "| MINOR | 0 |\n"
+        + "| INFO | 0 |\n\n\n"
+        + "| Issues list |\n"
+        + "|-------------|\n"
+        + "| *BLOCKER* - messageBlocker [[RepoBlocker:RuleBlocker](sonarqube/URL/coding_rules#rule_key=RepoBlocker:RuleBlocker)] |\n"
+        + "|    *Files: scripts/file1.example:1* |\n"
+        + "| *CRITICAL* - messageCritical [[RepoCritical:RuleCritical](sonarqube/URL/coding_rules#rule_key=RepoCritical:RuleCritical)] |\n"
+        + "|    *Files: scripts/file2.example, scripts/file2.example:1* |\n"
+        + "| *MAJOR* - messageMajor [[RepoMajor:RuleMajor](sonarqube/URL/coding_rules#rule_key=RepoMajor:RuleMajor)] |\n"
+        + "|    *Files: scripts/file3.example:1, scripts/file3.example:15, scripts/tests/file3.example:5* |\n";
+
+    assertEquals(reportString, issueReportMarkdown);
+
+  }
+
   @Test
   public void testPrintEmptyReportMarkdown() {
     report = new ArrayList<>();