Clean up TypeckResults::extract_binding_mode

meithecatte · meithecatte · commit de25d0d1320f · 2025-02-27T10:19:12.000+01:00
- Remove the `Option` from the result type, as `None` is never returned.
- Document the difference from the `BindingMode` in `PatKind::Binding`.
diff --git a/clippy_utils/src/lib.rs b/clippy_utils/src/lib.rs
@@ -1095,7 +1095,6 @@ pub fn capture_local_usage(cx: &LateContext<'_>, e: &Expr<'_>) -> CaptureKind {
         pat.each_binding_or_first(&mut |_, id, span, _| match cx
             .typeck_results()
             .extract_binding_mode(cx.sess(), id, span)
-            .unwrap()
             .0
         {
             ByRef::No if !is_copy(cx, cx.typeck_results().node_type(id)) => {

Original file line number	Diff line number	Diff line change
`@@ -1095,7 +1095,6 @@ pub fn capture_local_usage(cx: &LateContext<'_>, e: &Expr<'_>) -> CaptureKind {`
`1095`	`1095`	`pat.each_binding_or_first(&mut \|_, id, span, _\| match cx`
`1096`	`1096`	`.typeck_results()`
`1097`	`1097`	`.extract_binding_mode(cx.sess(), id, span)`
`1098`		`- .unwrap()`
`1099`	`1098`	`.0`
`1100`	`1099`	`{`
`1101`	`1100`	`ByRef::No if !is_copy(cx, cx.typeck_results().node_type(id)) => {`