Skip to content

Commit 21f7590

Browse files
committed
fix: last approved response
1 parent 875f10b commit 21f7590

File tree

4 files changed

+20
-13
lines changed

4 files changed

+20
-13
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ you need to be running those in order to run the automated tests:
4545

4646
TODO
4747

48+
### Bug
49+
50+
51+
52+
4853
### Run Validator Worker
4954

5055
TODO

primitives/src/sentry.rs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::collections::HashMap;
66
use std::fmt;
77
use std::hash::Hash;
88

9+
910
#[derive(Serialize, Deserialize, Debug)]
1011
#[serde(rename_all = "camelCase")]
1112
pub struct LastApproved {
@@ -19,21 +20,21 @@ pub struct LastApproved {
1920
pub struct NewStateValidatorMessage {
2021
pub from: String,
2122
pub received: DateTime<Utc>,
22-
pub msg: NewState,
23+
pub msg: MessageTypes,
2324
}
2425

2526
#[derive(Serialize, Deserialize, Debug)]
2627
pub struct ApproveStateValidatorMessage {
2728
pub from: String,
2829
pub received: DateTime<Utc>,
29-
pub msg: ApproveState,
30+
pub msg: MessageTypes,
3031
}
3132

3233
#[derive(Serialize, Deserialize, Debug)]
3334
pub struct HeartbeatValidatorMessage {
3435
pub from: String,
3536
pub received: DateTime<Utc>,
36-
pub msg: Heartbeat,
37+
pub msg: MessageTypes,
3738
}
3839

3940
#[serde(tag = "type", rename_all = "SCREAMING_SNAKE_CASE")]
@@ -245,7 +246,7 @@ mod postgres {
245246
Self {
246247
from: row.get("from"),
247248
received: row.get("received"),
248-
msg: row.get::<_, Json<ApproveState>>("msg").0,
249+
msg: row.get::<_, Json<MessageTypes>>("msg").0,
249250
}
250251
}
251252
}
@@ -255,7 +256,7 @@ mod postgres {
255256
Self {
256257
from: row.get("from"),
257258
received: row.get("received"),
258-
msg: row.get::<_, Json<NewState>>("msg").0,
259+
msg: row.get::<_, Json<MessageTypes>>("msg").0,
259260
}
260261
}
261262
}
@@ -265,7 +266,7 @@ mod postgres {
265266
Self {
266267
from: row.get("from"),
267268
received: row.get("received"),
268-
msg: row.get::<_, Json<Heartbeat>>("msg").0,
269+
msg: row.get::<_, Json<MessageTypes>>("msg").0,
269270
}
270271
}
271272
}

sentry/src/routes/channel.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,11 @@ pub async fn last_approved<A: Adapter>(
117117
.unwrap());
118118
}
119119

120-
let state_root = approve_state
121-
.as_ref()
122-
.expect("value should be present")
123-
.msg
124-
.state_root
125-
.clone();
120+
let state_root = match approve_state.as_ref().expect("value should be present").msg.clone() {
121+
MessageTypes::ApproveState(approve_state) => approve_state.state_root,
122+
_ => return Err(ResponseError::BadRequest("invalid request".to_string()))
123+
};
124+
126125
let new_state = latest_new_state(&app.pool, &channel, &state_root).await?;
127126
if new_state.is_none() {
128127
return Ok(Response::builder()

validator.env.dist

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,6 @@ ADAPTER=dummy
33
DUMMY_IDENTITY=ce07CbB7e054514D590a0262C93070D838bFBA2e
44
# for Ethereum adapter
55
#KEYSTORE_FILE="/app/keystore.json"
6-
#KEYSTORE_PWD="adexvalidator"
6+
#KEYSTORE_PWD="adexvalidator"
7+
8+

0 commit comments

Comments
 (0)