Skip to content

Commit 4106f2e

Browse files
committed
primitives - improve comment
1 parent 7d11d65 commit 4106f2e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

primitives/src/targeting/eval.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ impl TryFrom<SerdeValue> for Value {
5858
match serde_value {
5959
SerdeValue::Bool(bool) => Ok(Self::Bool(bool)),
6060
SerdeValue::Number(number) => Ok(Self::Number(number)),
61-
// String can be either a String or a BigNum
62-
// but we handle this case by using Type casting with the Function::Bn
61+
// It's impossible to have a BigNumber literal in the rules, since they're JSON based (conform to serde_json::value::Value)
62+
// However it is possible to obtain a BigNumber by invoking the Function::Bn
6363
SerdeValue::String(string) => Ok(Value::String(string)),
6464
SerdeValue::Array(serde_array) => {
6565
let array = serde_array

0 commit comments

Comments
 (0)