Issue #77 Move Workers and Validators to application layer (#80)

* validator - move `Leader`/`Follower` validators to `application`

* validator - move workers to `application`

* validator - main.rs - re-arrange imports

* sentry - domain - channel - repository - rename `create()` to `add()`

Author: elpiel

sentry/src/application/resource/channel/channel_create/handler.rs

@@ -31,7 +31,7 @@ impl ChannelCreateHandler {
             spec: channel_input.spec,
         };
 
-        let success = await!(self.channel_repository.create(channel)).is_ok();
+        let success = await!(self.channel_repository.add(channel)).is_ok();
 
         Ok(ChannelCreateResponse { success })
     }

sentry/src/domain/channel.rs

@@ -57,5 +57,5 @@ pub trait ChannelRepository: Debug + Send + Sync {
 
     fn find(&self, channel_id: &ChannelId) -> RepositoryFuture<Option<Channel>>;
 
-    fn create(&self, channel: Channel) -> RepositoryFuture<()>;
+    fn add(&self, channel: Channel) -> RepositoryFuture<()>;
 }

sentry/src/infrastructure/persistence/channel/memory.rs

@@ -83,7 +83,7 @@ impl ChannelRepository for MemoryChannelRepository {
         res_fut.boxed()
     }
 
-    fn create(&self, channel: Channel) -> RepositoryFuture<()> {
+    fn add(&self, channel: Channel) -> RepositoryFuture<()> {
         let channel_found = match self.records.read() {
             Ok(reader) => reader.iter().find_map(|current| {
                 if channel.id == current.id {

sentry/src/infrastructure/persistence/channel/memory_test.rs

@@ -174,7 +174,7 @@ fn saves_channels() {
 
         // save the 2nd channel
         // this shouldn't change the order in any way
-        await!(some_init.create(new_channel)).expect("Saving 2nd new channel");
+        await!(some_init.add(new_channel)).expect("Saving 2nd new channel");
 
         let params = ChannelListParams::new(valid_until_ge, 10, 1, None).unwrap();
         let channels_list: Vec<Channel> =
@@ -191,7 +191,7 @@ fn saves_channels() {
 
         // save the 2nd channel
         // this shouldn't change the order in any way
-        await!(some_init.create(new_channel)).expect("Saving 3rd new channel");
+        await!(some_init.add(new_channel)).expect("Saving 3rd new channel");
 
         let channels_list: Vec<Channel> =
             await!(some_init.list(&params)).expect("List the 3 total channels");
@@ -213,7 +213,7 @@ fn saving_the_same_channel_id_should_error() {
 
         let same_channel_id = get_channel("ABC", &None, None);
 
-        let error = await!(repository.create(same_channel_id))
+        let error = await!(repository.add(same_channel_id))
             .expect_err("It shouldn't be possible to save the same channel_id");
 
         match error {

sentry/src/infrastructure/persistence/channel/postgres.rs

@@ -72,7 +72,7 @@ impl ChannelRepository for PostgresChannelRepository {
         unimplemented!("find() for Postgres still needs to be implemented")
     }
 
-    fn create(&self, _channel: Channel) -> RepositoryFuture<()> {
+    fn add(&self, _channel: Channel) -> RepositoryFuture<()> {
         unimplemented!("create() for Postgres still needs to be implemented")
     }
 }

validator/src/application.rs

@@ -0,0 +1,2 @@
+pub mod validator;
+pub mod worker;

validator/src/infrastructure/validator.rs renamed to validator/src/application/validator.rs

@@ -11,8 +11,8 @@ pub mod single {
 
     use domain::{Channel, SpecValidator};
 
+    use crate::application::validator::{Follower, Leader};
     use crate::domain::{ChannelRepository, Validator, Worker, WorkerFuture};
-    use crate::infrastructure::validator::{Follower, Leader};
 
     #[derive(Clone)]
     pub struct TickWorker {
@@ -95,8 +95,8 @@ pub mod infinite {
     use futures::future::{join, FutureExt};
     use tokio::timer::Delay;
 
+    use crate::application::worker::TickWorker;
     use crate::domain::{Worker, WorkerFuture};
-    use crate::infrastructure::worker::TickWorker;
 
     #[derive(Clone)]
     pub struct InfiniteWorker {