Merge pull request #175 from AdExNetwork/adapter-safety

follower: clone the adapter rather than drop

Author: Ivo Georgiev

validator_worker/src/follower.rs

@@ -64,14 +64,13 @@ async fn on_new_state<'a, A: Adapter + 'static>(
         return Ok(on_error(&iface, &new_state, InvalidNewState::RootHash).await);
     }
 
-    let adapter = iface.adapter.read().await;
+    let adapter = iface.adapter.read().await.clone();
 
     if !adapter.verify(
         &iface.channel.spec.validators.leader().id,
         &proposed_state_root,
         &new_state.signature,
     )? {
-        drop(adapter);
         return Ok(on_error(&iface, &new_state, InvalidNewState::Signature).await);
     }
 
@@ -82,7 +81,6 @@ async fn on_new_state<'a, A: Adapter + 'static>(
         .map_or(Default::default(), |new_state| new_state.msg.balances);
 
     if !is_valid_transition(&iface.channel, &prev_balances, &proposed_balances) {
-        drop(adapter);
         return Ok(on_error(&iface, &new_state, InvalidNewState::Transition).await);
     }
 
@@ -95,8 +93,6 @@ async fn on_new_state<'a, A: Adapter + 'static>(
         &health_threshold,
     );
 
-    drop(adapter);
-
     iface
         .propagate(&[&MessageTypes::ApproveState(ApproveState {
             state_root: proposed_state_root,