clean-up & fix tests usage of config

Author: elpiel

adapter/src/dummy.rs

@@ -53,7 +53,7 @@ impl Dummy {
 
     /// Set the deposit that you want the adapter to return every time
     /// when the [`get_deposit()`](Locked::get_deposit) get's called
-    /// for the give [`ChannelId`] and [`Address`].
+    /// for the give [`ChannelId`](primitives::ChannelId) and [`Address`].
     ///
     /// If [`Deposit`] is set to [`None`], it remove the mocked deposit.
     ///
@@ -281,7 +281,7 @@ mod deposit {
     /// Mocked deposits for the Dummy adapter.
     ///
     /// These deposits can be set once and the adapter will return
-    /// the set deposit on every call to [`get_deposit()`](`Locked::get_deposit`).
+    /// the set deposit on every call to [`get_deposit()`](crate::client::Locked::get_deposit).
     #[derive(Debug, Clone, Default)]
     pub struct Deposits(pub Arc<DashMap<Key, Deposit>>);
 

adapter/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(rust_2018_idioms)]
 #![deny(clippy::all)]
+#![deny(rustdoc::broken_intra_doc_links)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 
 pub use {

adview-manager/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(rust_2018_idioms)]
 #![deny(clippy::all)]
+#![deny(rustdoc::broken_intra_doc_links)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 
 use adex_primitives::{

primitives/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(rust_2018_idioms)]
 #![deny(clippy::all)]
+#![deny(rustdoc::broken_intra_doc_links)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 // TODO: Remove once stabled and upstream num::Integer::div_floor(...) is fixed
 #![allow(unstable_name_collisions)]

sentry/src/lib.rs

@@ -1,5 +1,6 @@
-#![deny(clippy::all)]
 #![deny(rust_2018_idioms)]
+#![deny(clippy::all)]
+#![deny(rustdoc::broken_intra_doc_links)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 
 #[doc(inline)]

sentry/src/routes/channel.rs

@@ -557,7 +557,7 @@ pub async fn channel_payout<C: Locked + 'static>(
 
 /// POST `/v5/channel/dummy-deposit` request
 ///
-/// Request body (json): [`ChannelDummyDeposit`]
+/// Body (json): [`ChannelDummyDeposit`]
 ///
 /// Response: [`SuccessResponse`]
 pub async fn channel_dummy_deposit<C: Locked + 'static>(

sentry/src/routes/routers.rs

@@ -254,7 +254,7 @@ pub async fn channels_router<C: Locked + 'static>(
         channel_payout(req, app).await
     }
     // POST /v5/channel/dummy-deposit
-    // will allow the calling of the method only if we are using the Dummy adapter!
+    // We allow the calling of the method only if we are using the Dummy adapter!
     else if let (Some(caps), &Method::POST, true) = (
         CHANNEL_DUMMY_ADAPTER_DEPOSIT.captures(&path),
         method,
@@ -265,11 +265,7 @@ pub async fn channels_router<C: Locked + 'static>(
             .map_or("".to_string(), |m| m.as_str().to_string())]);
         req.extensions_mut().insert(param);
 
-        req = Chain::new()
-            .chain(AuthRequired)
-            // .chain(ChannelLoad)
-            .apply(req, app)
-            .await?;
+        req = Chain::new().chain(AuthRequired).apply(req, app).await?;
 
         channel_dummy_deposit(req, app).await
     } else {

validator_worker/src/follower.rs

@@ -371,7 +371,7 @@ mod test {
         let adapter = Adapter::with_unlocked(Dummy::init(Options {
             dummy_identity: IDS[&LEADER],
             dummy_auth_tokens: DUMMY_AUTH.clone(),
-            dummy_chains: GANACHE_CONFIG.chains.values().cloned().collect(),
+            dummy_chains: config.chains.values().cloned().collect(),
         }));
         let logger = discard_logger();
 

validator_worker/src/heartbeat.rs

@@ -128,7 +128,7 @@ mod test {
         let adapter = Adapter::with_unlocked(Dummy::init(Options {
             dummy_identity: IDS[&LEADER],
             dummy_auth_tokens: DUMMY_AUTH.clone(),
-            dummy_chains: GANACHE_CONFIG.chains.values().cloned().collect(),
+            dummy_chains: config.chains.values().cloned().collect(),
         }));
         let logger = discard_logger();
 

validator_worker/src/leader.rs

@@ -161,7 +161,7 @@ mod test {
         let adapter = Adapter::with_unlocked(Dummy::init(Options {
             dummy_identity: IDS[&LEADER],
             dummy_auth_tokens: DUMMY_AUTH.clone(),
-            dummy_chains: GANACHE_CONFIG.chains.values().cloned().collect(),
+            dummy_chains: config.chains.values().cloned().collect(),
         }));
         let logger = discard_logger();