remove commented out tests

Author: elpiel

primitives/src/channel_validator.rs

@@ -69,170 +69,3 @@ pub fn asset_listed(channel: &Channel, whitelist: &[String]) -> bool {
             .iter()
             .any(|allowed| allowed == &channel.deposit_asset)
 }
-
-//#[cfg(test)]
-//mod test {
-//    use time::Duration;
-//
-//    use domain::channel::fixtures::{get_channel_spec, ValidatorsOption};
-//    use domain::fixtures::{get_channel, get_validator};
-//
-//    use crate::adapter::ConfigBuilder;
-//
-//    use super::*;
-//
-//    pub struct DummySanityChecker {}
-//    impl SanityChecker for DummySanityChecker {}
-//
-//    #[test]
-//    fn sanity_check_disallows_channels_without_current_adapter() {
-//        let channel = get_channel("channel_1", &None, None);
-//        let config = ConfigBuilder::new("non_existent_validator").build();
-//        assert_eq!(
-//            Err(SanityError::AdapterNotIncluded),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_channels_with_passed_valid_until() {
-//        let passed_valid_until = Utc::now() - Duration::seconds(1);
-//        let channel = get_channel("channel_1", &Some(passed_valid_until), None);
-//
-//        let identity = channel.spec.validators.leader().id.clone();
-//        let config = ConfigBuilder::new(&identity).build();
-//
-//        assert_eq!(
-//            Err(SanityError::PassedValidUntil),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_channels_with_unlisted_in_whitelist_validators() {
-//        let channel = get_channel("channel_1", &None, None);
-//
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let identity = channel.spec.validators.leader().id.clone();
-//        let config = ConfigBuilder::new(&identity)
-//            .set_validators_whitelist(&["my validator"])
-//            .build();
-//
-//        // make sure we don't use the leader or follower validators as a whitelisted validator
-//        assert_ne!(
-//            &identity, "my validator",
-//            "The whitelisted validator and the leader have the same id"
-//        );
-//        assert_ne!(
-//            &channel.spec.validators.follower().id,
-//            "my validator",
-//            "The whitelisted validator and the follower have the same id"
-//        );
-//
-//        assert_eq!(
-//            Err(SanityError::UnlistedValidator),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_channels_with_unlisted_creator() {
-//        let channel = get_channel("channel_1", &None, None);
-//
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let identity = channel.spec.validators.leader().id.clone();
-//        let config = ConfigBuilder::new(&identity)
-//            .set_creators_whitelist(&["creator"])
-//            .build();
-//
-//        assert_ne!(
-//            &channel.creator, "creator",
-//            "The channel creator should be different than the whitelisted creator"
-//        );
-//
-//        assert_eq!(
-//            Err(SanityError::UnlistedCreator),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_channels_with_unlisted_asset() {
-//        let channel = get_channel("channel_1", &None, None);
-//
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let identity = channel.spec.validators.leader().id.clone();
-//        let config = ConfigBuilder::new(&identity)
-//            .set_assets_whitelist(&["ASSET".into()])
-//            .build();
-//
-//        assert_ne!(
-//            &channel.deposit_asset,
-//            &"ASSET".into(),
-//            "The channel deposit_asset should be different than the whitelisted asset"
-//        );
-//
-//        assert_eq!(
-//            Err(SanityError::UnlistedAsset),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_channel_deposit_less_than_minimum_deposit() {
-//        let channel = get_channel("channel_1", &None, None);
-//
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let identity = channel.spec.validators.leader().id.clone();
-//        let config = ConfigBuilder::new(&identity)
-//            // set the minimum deposit to the `channel.deposit_amount + 1`
-//            .set_minimum_deposit(&channel.deposit_amount + &1.into())
-//            .build();
-//
-//        assert_eq!(
-//            Err(SanityError::MinimumDepositNotMet),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_disallows_validator_fee_less_than_minimum_fee() {
-//        let channel = get_channel("channel_1", &None, None);
-//
-//        let leader = channel.spec.validators.leader();
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let identity = leader.id.clone();
-//        let config = ConfigBuilder::new(&identity)
-//            // set the minimum deposit to the `leader.fee + 1`
-//            .set_minimum_fee(&leader.fee + &1.into())
-//            .build();
-//
-//        assert_eq!(
-//            Err(SanityError::MinimumValidatorFeeNotMet),
-//            DummySanityChecker::check(&config, &channel)
-//        )
-//    }
-//
-//    #[test]
-//    fn sanity_check_allows_for_valid_values() {
-//        let validators = [
-//            get_validator("my leader", Some(10.into())),
-//            get_validator("my follower", Some(15.into())),
-//        ];
-//        let spec = get_channel_spec(ValidatorsOption::SpecValidators(validators.into()));
-//        let channel = get_channel("channel_1", &None, Some(spec));
-//
-//        // as identity use the leader, otherwise we won't pass the AdapterNotIncluded check
-//        let config = ConfigBuilder::new("my leader")
-//            .set_validators_whitelist(&["my leader", "my follower"])
-//            .set_creators_whitelist(&[&channel.creator])
-//            .set_assets_whitelist(&[channel.deposit_asset.clone()])
-//            // set the minimum deposit to the `channel.deposit_amount - 1`
-//            .set_minimum_deposit(&channel.deposit_amount - &1.into())
-//            // set the minimum fee to the `leader.fee - 1`, i.e. `10 - 1 = 9`
-//            .set_minimum_fee(9.into())
-//            .build();
-//
-//        assert!(DummySanityChecker::check(&config, &channel).is_ok())
-//    }
-//}