Skip to content

Commit d6c8b1d

Browse files
committed
add: types to EventData
1 parent 7121cb0 commit d6c8b1d

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

sentry/migrations/20190806011140_initial-tables/up.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ CREATE TABLE event_aggregates
3131
created TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT NOW(),
3232
event_type VARCHAR(255) NOT NULL,
3333
earner VARCHAR(255),
34-
count BIGINT NOT NULL,
35-
payout BIGINT NOT NULL
34+
count VARCHAR NOT NULL,
35+
payout VARCHAR NOT NULL
3636
);
3737

3838
CREATE INDEX idx_event_aggregates_created ON event_aggregates (created);

sentry/src/db/event_aggregate.rs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ pub async fn list_event_aggregates(
8989

9090
#[derive(Debug)]
9191
struct EventData {
92-
id: String,
92+
id: ChannelId,
9393
event_type: String,
94-
earner: Option<String>,
94+
earner: Option<ValidatorId>,
9595
event_count: BigNum,
9696
event_payout: BigNum,
9797
created: DateTime<Utc>,
@@ -102,7 +102,6 @@ pub async fn insert_event_aggregate(
102102
channel_id: &ChannelId,
103103
event: &EventAggregate,
104104
) -> Result<bool, RunError<bb8_postgres::tokio_postgres::Error>> {
105-
let id = channel_id.to_string();
106105
let created = Utc::now();
107106

108107
let mut data: Vec<EventData> = Vec::new();
@@ -115,9 +114,9 @@ pub async fn insert_event_aggregate(
115114
let event_payout = aggr.event_payouts[earner].clone();
116115

117116
data.push(EventData {
118-
id: id.clone(),
117+
id: channel_id.to_owned(),
119118
event_type: event_type.clone(),
120-
earner: Some(earner.to_string()),
119+
earner: Some(earner.clone()),
121120
event_count: event_count.to_owned(),
122121
event_payout: event_payout.clone(),
123122
created,
@@ -129,7 +128,7 @@ pub async fn insert_event_aggregate(
129128
}
130129

131130
data.push(EventData {
132-
id: id.clone(),
131+
id: channel_id.to_owned(),
133132
event_type: event_type.clone(),
134133
earner: None,
135134
event_count: total_event_counts,
@@ -148,10 +147,10 @@ pub async fn insert_event_aggregate(
148147
Err(e) => return Err((e, connection))
149148
};
150149

151-
let writer = BinaryCopyInWriter::new(sink, &[Type::VARCHAR, Type::TIMESTAMPTZ, Type::VARCHAR, Type::INT8, Type::INT8, Type::VARCHAR]);
150+
let writer = BinaryCopyInWriter::new(sink, &[Type::VARCHAR, Type::TIMESTAMPTZ, Type::VARCHAR, Type::VARCHAR, Type::VARCHAR, Type::VARCHAR]);
152151
pin_mut!(writer);
153152
for item in data {
154-
if let Err(e) = writer.as_mut().write(&[&item.id, &item.created, &item.event_type, &item.event_count.to_i64().expect("should have i64"), &item.event_payout.to_i64().expect("should have i64"), &item.earner]).await {
153+
if let Err(e) = writer.as_mut().write(&[&item.id, &item.created, &item.event_type, &item.event_count, &item.event_payout, &item.earner]).await {
155154
err = Some(e);
156155
break;
157156
}

0 commit comments

Comments
 (0)