sentry - access - Move ChannelIsExpired check on top of all checks

Author: elpiel

sentry/src/access.rs

@@ -31,6 +31,10 @@ pub async fn check_access(
     let current_time = Utc::now();
     let is_in_withdraw_period = current_time > channel.spec.withdraw_period_start;
 
+    if current_time > channel.valid_until {
+        return Err(Error::ChannelIsExpired);
+    }
+
     // We're only sending a CLOSE
     // That's allowed for the creator normally, and for everyone during the withdraw period
     if events.iter().all(is_close_event)
@@ -44,10 +48,6 @@ pub async fn check_access(
         return Err(Error::OnlyCreatorCanCloseChannel);
     }
 
-    if current_time > channel.valid_until {
-        return Err(Error::ChannelIsExpired);
-    }
-
     if is_in_withdraw_period {
         return Err(Error::ChannelIsInWithdrawPeriod);
     }