Lock nightly and fix some warnings (#157)

* primitives - big_num - fix `clippy` warnings about `to_owned()`

* Lock `nightly` version in `rust-toolchain` & `travis`, fix `rustfmt` & `clippy` warnings

Author: elpiel

.travis.yml

@@ -1,6 +1,6 @@
 language: rust
 rust:
-  - nightly
+  - nightly-2019-10-14
 cache: cargo
 env:
   global:

adapter/src/ethereum.rs

@@ -477,8 +477,7 @@ mod test {
             "eyJ0eXBlIjoiSldUIiwiYWxnIjoiRVRIIn0.eyJpZCI6ImF3ZXNvbWVWYWxpZGF0b3IiLCJlcmEiOjEwMDAwMCwiYWRkcmVzcyI6IjB4MmJEZUFGQUU1Mzk0MDY2OURhQTZGNTE5MzczZjY4NmMxZjNkMzM5MyJ9.gGw_sfnxirENdcX5KJQWaEt4FVRvfEjSLD4f3OiPrJIltRadeYP2zWy9T2GYcK5xxD96vnqAw4GebAW7rMlz4xw";
         assert_eq!(response, expected, "generated wrong ewt signature");
 
-        let expected_verification_response =
-            r#"VerifyPayload { from: "0x2bDeAFAE53940669DaA6F519373f686c1f3d3393", payload: Payload { id: "awesomeValidator", era: 100000, address: Some("0x2bDeAFAE53940669DaA6F519373f686c1f3d3393"), identity: None } }"#;
+        let expected_verification_response = r#"VerifyPayload { from: "0x2bDeAFAE53940669DaA6F519373f686c1f3d3393", payload: Payload { id: "awesomeValidator", era: 100000, address: Some("0x2bDeAFAE53940669DaA6F519373f686c1f3d3393"), identity: None } }"#;
 
         let parts: Vec<&str> = expected.split('.').collect();
         let verification =

adapter/src/lib.rs

@@ -175,7 +175,7 @@ impl EthereumChannel {
 
     pub fn hash_hex(&self, contract_addr: &str) -> Result<String, Box<dyn Error>> {
         let result = self.hash(contract_addr)?;
-        Ok(format!("0x{}", hex::encode(result).to_string()))
+        Ok(format!("0x{}", hex::encode(result)))
     }
 
     pub fn to_solidity_tuple(&self) -> Vec<String> {
@@ -203,7 +203,7 @@ impl EthereumChannel {
         balance_root: &str,
     ) -> Result<String, Box<dyn Error>> {
         let result = self.hash_to_sign(contract_addr, balance_root)?;
-        Ok(format!("0x{}", hex::encode(result).to_string()))
+        Ok(format!("0x{}", hex::encode(result)))
     }
 }
 

adview-manager/src/lib.rs

@@ -291,7 +291,7 @@ fn get_unit_html(
         </div>
     ", target_url = ad_unit.target_url, size = style_size, element_html = element_html, adex_icon = adex_icon);
 
-    result.to_string()
+    result
 }
 
 #[cfg(test)]

primitives/src/big_num.rs

@@ -91,7 +91,7 @@ impl Add<&BigNum> for &BigNum {
 
     fn add(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 + &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 
@@ -106,7 +106,7 @@ impl Sub<&BigNum> for &BigNum {
 
     fn sub(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 - &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 
@@ -115,7 +115,7 @@ impl Div<&BigNum> for &BigNum {
 
     fn div(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 / &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 
@@ -124,7 +124,7 @@ impl Div<&BigNum> for BigNum {
 
     fn div(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 / &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 
@@ -133,7 +133,7 @@ impl Mul<&BigNum> for &BigNum {
 
     fn mul(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 * &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 
@@ -142,7 +142,7 @@ impl Mul<&BigNum> for BigNum {
 
     fn mul(self, rhs: &BigNum) -> Self::Output {
         let big_uint = &self.0 * &rhs.0;
-        BigNum(big_uint.to_owned())
+        BigNum(big_uint)
     }
 }
 

rust-toolchain

@@ -1 +1 @@
-nightly
+nightly-2019-10-14

validator_worker/src/main.rs

@@ -101,7 +101,7 @@ fn main() {
 // @TODO work in separate pull request
 fn run(_is_single_tick: bool, sentry: &str, config: &Config, adapter: impl Adapter + 'static) {
     let _sentry_url = sentry.to_owned();
-    let _adapter = adapter.clone();
+    let _adapter = adapter;
     let _config = config.clone();
 
     // let result = async move {