Skip to content

Commit 02fa510

Browse files
committed
chore: resolve merge
2 parents 24f56ac + 2ab7541 commit 02fa510

File tree

13 files changed

+6362
-647
lines changed

13 files changed

+6362
-647
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @bgrnwd @tyler-richardett @mattyanselmo @rvino
1+
* @American-Soccer-Analysis/contributors

Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Base image https://hub.docker.com/u/rocker/
22
# Match R version in renv.lock
3-
FROM rocker/r-ver:4.0.0 AS deps
3+
FROM rocker/r-ver:4.5.2 AS deps
44
WORKDIR /code
55
# Install system dependencies
66
RUN apt-get update -qq && apt-get -y --no-install-recommends install \
@@ -18,7 +18,8 @@ RUN apt-get update -qq && apt-get -y --no-install-recommends install \
1818
libpng-dev \
1919
libtiff5-dev \
2020
libjpeg-dev \
21-
default-jdk
21+
default-jdk \
22+
cmake
2223

2324
# Update all system packages
2425
RUN apt-get update && \

config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ tabs:
2424
- Tables:
2525
- route_link: xgoals
2626
display_name: xGoals
27-
icon: futbol-o
27+
icon: futbol
2828
subheaders: [Players, Teams, Games, Goalkeepers]
2929
ui: tables_ui
3030
leagues: [mls, nwsl, usls, uslc, usl1, mlsnp, nasl]

global.R

Lines changed: 30 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@ tables_normalize_columns <- unique(tmp_tables$api_name[!is.na(tmp_tables$normali
8080

8181
# Initialize shiny router -----------------------
8282
tab_groups <- sapply(tab_config, names)
83-
router_list_to_parse <- "router <- make_router(default = "
83+
router_list_to_parse <- "router <- router_ui("
8484

8585
for (league in league_schemas) {
8686
router_list_to_parse <- paste0(router_list_to_parse, "route(\"",
8787
league, "\", ",
88-
"home_ui", ", ",
89-
NA, "), ")
88+
"home_ui",
89+
"), ")
9090
for (tab_group in tab_groups) {
9191
i <- which(tab_groups == tab_group)
9292
tabs <- tab_config[[i]][[tab_group]]
@@ -96,16 +96,26 @@ for (league in league_schemas) {
9696
subheaders <- tab$subheaders
9797
if (!is.null(subheaders)) {
9898
for (s in subheaders) {
99-
router_list_to_parse <- paste0(router_list_to_parse, "route(\"",
100-
paste0(league, "/", header, "/", tolower(s)), "\", ",
101-
tab$ui, ", ",
102-
tab$server, "), ")
99+
route_path <- paste0(league, "/", header, "/", tolower(s))
100+
route_id <- gsub("/", "_", route_path)
101+
102+
router_list_to_parse <- paste0(
103+
router_list_to_parse,
104+
"route(\"", route_path, "\", ",
105+
tab$ui, "(id = \"", route_id, "\")",
106+
"), "
107+
)
103108
}
104109
} else {
105-
router_list_to_parse <- paste0(router_list_to_parse, "route(\"",
106-
paste0(league, "/", header), "\", ",
107-
tab$ui, ", ",
108-
tab$server, "), ")
110+
route_path <- paste0(league, "/", header)
111+
route_id <- gsub("/", "_", route_path)
112+
113+
router_list_to_parse <- paste0(
114+
router_list_to_parse,
115+
"route(\"", route_path, "\", ",
116+
tab$ui, "(id = \"", route_id, "\")",
117+
"), "
118+
)
109119
}
110120
}
111121
}
@@ -204,9 +214,16 @@ get_config_element <- function(league, tab_group, route_prefix, tab_config, elem
204214
tab_groups <- sapply(tab_config, names)
205215
i <- which(tab_groups == tab_group)
206216

217+
if (length(i) == 0) {
218+
return(NULL)
219+
}
220+
207221
tab <- tab_config[[i]][[tab_group]]
208222
route_links <- sapply(tab, "[[", "route_link")
209223
j <- which(route_links == route_prefix)
224+
if (length(j) == 0) {
225+
return(NULL)
226+
}
210227

211228
return(tab[[j]][[element]])
212229
}
@@ -219,8 +236,8 @@ get_values_from_page <- function(page) {
219236

220237
return(list(
221238
league = league,
222-
route_prefix = ifelse(nchar(route_prefix) == 0, NA, route_prefix),
223-
subheader = ifelse(nchar(subheader) == 0, NA, subheader)
239+
route_prefix = if (nchar(route_prefix) == 0) NA_character_ else route_prefix,
240+
subheader = if (nchar(subheader) == 0) NA_character_ else subheader
224241
))
225242
}
226243

renv.lock

Lines changed: 4896 additions & 430 deletions
Large diffs are not rendered by default.

renv/.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
local/
2+
cellar/
3+
lock/
4+
sandbox/
15
library/
26
python/
37
staging/

0 commit comments

Comments
 (0)