nit: access modifiers and comments

Author: zyfy29

app/src/androidTest/java/com/amrdeveloper/linkhub/ShareLinkTest.kt

@@ -17,7 +17,7 @@ class ShareLinkTest {
     @get:Rule
     val intentsTestRule = IntentsTestRule(MainActivity::class.java, true, false)
 
-    fun runCaseFor(sharedLink: String, title: String, subTitle: String) {
+    private fun runCaseFor(sharedLink: String, title: String, subTitle: String) {
         val intent = Intent(Intent.ACTION_SEND).apply {
             putExtra(Intent.EXTRA_TEXT, sharedLink)
         }
@@ -43,6 +43,7 @@ class ShareLinkTest {
 
     @Test
     fun linkContainsSpace() {
+        // not a valid URI, skip generation
         runCaseFor("https://www.example.com/hello world", "", "")
     }
 }

app/src/main/java/com/amrdeveloper/linkhub/ui/link/LinkViewModel.kt

@@ -73,10 +73,12 @@ class LinkViewModel @Inject constructor(
         }
     }
 
+    private fun isValidURI(url: String) =
+        URLUtil.isValidUrl(url) && runCatching { URI(url) }.isSuccess
+
     fun generateLinkTitleAndSubTitle(url: String) {
         viewModelScope.launch(Dispatchers.IO) {
-            val isValidLink = URLUtil.isValidUrl(url) && runCatching { URI(url) }.isSuccess
-            if (isValidLink.not()) return@launch
+            if (isValidURI(url).not()) return@launch
             val linkInfo = generateLinkInfo(url)
             withContext(Dispatchers.Main) {
                 linkInfoLiveData.value = linkInfo